Delete instance methods.

Delete instance methods.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41764

[ahe, 2014-11-11 09:01:27]

Patchset #1 (id:1) has been deleted

[ahe, 2014-11-11 09:02:34]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2014-11-14 08:55:26]

lgtm

https://codereview.chromium.org/714843002/diff/20001/dart/pkg/dart2js_increme...
File dart/pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/714843002/diff/20001/dart/pkg/dart2js_increme...
dart/pkg/dart2js_incremental/lib/library_updater.dart:349: List<Element>
applyUpdates([List<Update> removals]) {
Document this, especially semantics of the return value.

https://codereview.chromium.org/714843002/diff/20001/dart/pkg/dart2js_increme...
dart/pkg/dart2js_incremental/lib/library_updater.dart:609: element, 'Removal of
non-instance methods not yest supported.');
non-instance -> static

[ahe, 2014-11-14 14:33:12]

Thank you, Johnni!

https://codereview.chromium.org/714843002/diff/20001/dart/pkg/dart2js_increme...
File dart/pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/714843002/diff/20001/dart/pkg/dart2js_increme...
dart/pkg/dart2js_incremental/lib/library_updater.dart:349: List<Element>
applyUpdates([List<Update> removals]) {
On 2014/11/14 08:55:26, Johnni Winther wrote:
> Document this, especially semantics of the return value.

Will do in a follow-up.

https://codereview.chromium.org/714843002/diff/20001/dart/pkg/dart2js_increme...
dart/pkg/dart2js_incremental/lib/library_updater.dart:609: element, 'Removal of
non-instance methods not yest supported.');
On 2014/11/14 08:55:26, Johnni Winther wrote:
> non-instance -> static

You missed the misspelling of "yet" ;-)

Regardless, this goes away in one of the other CL you have already reviewed, or
will review soon.

But there's a reason why I use "non-instance" instead of "static". In our world,
we consider a top-level method to be a static method, yet the keyword "static"
isn't legal on a top-level method. So when formatting an error message, I prefer
saying "static or top-level", but I figured "non-instance" would be just as
descriptive. But I'm not sure that's actually true.

[ahe, 2014-11-17 09:51:26]

Committed patchset #1 (id:20001) manually as 41764 (presubmit successful).