[cr tool] Adding the main function and remaining pieces.

Adding the main function and remaining pieces.

BUG=316397
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235983

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236244

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236259

[bulach, 2013-11-14 16:40:16]

lgtm, just nits:

https://codereview.chromium.org/71483003/diff/40001/tools/cr/cr.sh
File tools/cr/cr.sh (right):

https://codereview.chromium.org/71483003/diff/40001/tools/cr/cr.sh#newcode9
tools/cr/cr.sh:9: cr_main="$cr_base_dir/main.py"
perhaps ${cr_base_dir} here and ${cr_main} below?

https://codereview.chromium.org/71483003/diff/40001/tools/cr/cr.sh#newcode20
tools/cr/cr.sh:20: cd `cr info -s CR_SRC`
nit: perhaps $(..) ?

https://codereview.chromium.org/71483003/diff/40001/tools/cr/cr.sh#newcode32
tools/cr/cr.sh:32: local main="python -B "$cr_main")"
nit: perhaps ${cr_main} as well?

https://codereview.chromium.org/71483003/diff/40001/tools/cr/cr/autocomplete.py
File tools/cr/cr/autocomplete.py (right):

https://codereview.chromium.org/71483003/diff/40001/tools/cr/cr/autocomplete....
tools/cr/cr/autocomplete.py:17: COMP_WORD contains the word that is being
completed, and COMP_CWORD has
I think COMP_WORD usage will show up later on? maybe best to remove from here,
wdyt?

https://codereview.chromium.org/71483003/diff/40001/tools/cr/main.py
File tools/cr/main.py (right):

https://codereview.chromium.org/71483003/diff/40001/tools/cr/main.py#newcode85
tools/cr/main.py:85: "Running cr " + command.name + " for {CR_BUILD_DIR}")
nit: s/"/'/ everywhere..

[ian_cottrell, 2013-11-15 10:28:51]

https://codereview.chromium.org/71483003/diff/40001/tools/cr/cr.sh
File tools/cr/cr.sh (right):

https://codereview.chromium.org/71483003/diff/40001/tools/cr/cr.sh#newcode9
tools/cr/cr.sh:9: cr_main="$cr_base_dir/main.py"
On 2013/11/14 16:40:16, bulach wrote:
> perhaps ${cr_base_dir} here and ${cr_main} below?

Done.

https://codereview.chromium.org/71483003/diff/40001/tools/cr/cr.sh#newcode20
tools/cr/cr.sh:20: cd `cr info -s CR_SRC`
On 2013/11/14 16:40:16, bulach wrote:
> nit: perhaps $(..) ?

Done.

https://codereview.chromium.org/71483003/diff/40001/tools/cr/cr.sh#newcode32
tools/cr/cr.sh:32: local main="python -B "$cr_main")"
On 2013/11/14 16:40:16, bulach wrote:
> nit: perhaps ${cr_main} as well?

Done.

https://codereview.chromium.org/71483003/diff/40001/tools/cr/cr/autocomplete.py
File tools/cr/cr/autocomplete.py (right):

https://codereview.chromium.org/71483003/diff/40001/tools/cr/cr/autocomplete....
tools/cr/cr/autocomplete.py:17: COMP_WORD contains the word that is being
completed, and COMP_CWORD has
On 2013/11/14 16:40:16, bulach wrote:
> I think COMP_WORD usage will show up later on? maybe best to remove from here,
> wdyt?

I thought it was worth documenting because it's part of the formal contract
between cr.sh and main.py, it is effectively a parameter of this function, but
passed in a global, an ugly but necessary evil of the completion to bash to
python flow.

https://codereview.chromium.org/71483003/diff/40001/tools/cr/main.py
File tools/cr/main.py (right):

https://codereview.chromium.org/71483003/diff/40001/tools/cr/main.py#newcode85
tools/cr/main.py:85: "Running cr " + command.name + " for {CR_BUILD_DIR}")
On 2013/11/14 16:40:16, bulach wrote:
> nit: s/"/'/ everywhere..

Thought I had caught all those with my crazy greps, not sure how I missed this
file. Sorry.

[commit-bot: I haz the power, 2013-11-19 09:40:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iancottrell@chromium.org/71483003/100001

[commit-bot: I haz the power, 2013-11-19 09:56:36]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-11-19 10:29:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iancottrell@chromium.org/71483003/220001

[commit-bot: I haz the power, 2013-11-19 12:24:01]

Change committed as 235983

[commit-bot: I haz the power, 2013-11-20 10:25:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iancottrell@chromium.org/71483003/410001

[commit-bot: I haz the power, 2013-11-20 14:06:38]

Change committed as 236244

[commit-bot: I haz the power, 2013-11-20 15:39:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iancottrell@chromium.org/71483003/660001

[commit-bot: I haz the power, 2013-11-20 17:31:13]

Change committed as 236259