Issue 7148022: Reland 89038, but with a mocked out keychain (mac unit tests were timing out)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7148022: Reland 89038, but with a mocked out keychain (mac unit tests were timing out) (Closed)

Created:
9 years, 6 months ago by Nicolas Zea

Modified:
9 years, 6 months ago

Reviewers:
commit-bot: I haz the power, Andrew T Wilson (Slow)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Reland 89038, but with a mocked out keychain (mac unit tests were timing out) Original codereview at http://codereview.chromium.org/7108067/. BUG=81152 TEST=same as 89038 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89105

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -53 lines)			Patch
M	chrome/browser/sync/engine/syncapi.h	View	2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/syncapi.cc	View	2	9 chunks	+58 lines, -48 lines	0 comments	Download
M	chrome/browser/sync/engine/syncapi_unittest.cc	View	2	4 chunks	+90 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.cc	View	2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/util/cryptographer.cc	View	2	1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/util/cryptographer_unittest.cc	View	2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/util/nigori.cc	View	2	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Nicolas Zea

A quickie, just to reland and my previous patch (sync_unit_tests were timing out waiting on ...

9 years, 6 months ago (2011-06-14 21:32:57 UTC) #1

Change committed as 89105