Issue 7148005: Merge 88738 - [Chromium] WebNotification should check if ScriptExecutionContext is gone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7148005: Merge 88738 - [Chromium] WebNotification should check if ScriptExecutionContext is gone (Closed)

Created:
9 years, 6 months ago by jianli

Modified:
9 years, 6 months ago

Reviewers:
jianli

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/782/

Visibility:
Public.

Description

Merge 88738 - [Chromium] WebNotification should check if ScriptExecutionContext is gone before dispatching events. https://bugs.webkit.org/show_bug.cgi?id=62592 Reviewed by David Levin. * public/WebNotification.h: * src/WebNotification.cpp: (WebKit::WebNotification::dispatchDisplayEvent): (WebKit::WebNotification::dispatchErrorEvent): (WebKit::WebNotification::dispatchCloseEvent): (WebKit::WebNotification::dispatchClickEvent): (WebKit::WebNotification::dispatchEvent): Added a helper method to check the context and dispatch an event. TBR=jianli@chromium.org BUG=84660 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88743

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
	M	Source/WebKit/chromium/public/WebNotification.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
	M	Source/WebKit/chromium/src/WebNotification.cpp	View		1 chunk	+13 lines, -7 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages