Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 7148005: Merge 88738 - [Chromium] WebNotification should check if ScriptExecutionContext is gone (Closed)

Created:
8 years ago by jianli
Modified:
7 years, 12 months ago
Reviewers:
jianli
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/782/
Visibility:
Public.

Description

Merge 88738 - [Chromium] WebNotification should check if ScriptExecutionContext is gone before dispatching events. https://bugs.webkit.org/show_bug.cgi?id=62592 Reviewed by David Levin. * public/WebNotification.h: * src/WebNotification.cpp: (WebKit::WebNotification::dispatchDisplayEvent): (WebKit::WebNotification::dispatchErrorEvent): (WebKit::WebNotification::dispatchCloseEvent): (WebKit::WebNotification::dispatchClickEvent): (WebKit::WebNotification::dispatchEvent): Added a helper method to check the context and dispatch an event. TBR=jianli@chromium.org BUG=84660 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M Source/WebKit/chromium/public/WebNotification.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebNotification.cpp View 1 chunk +13 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jianli
8 years ago (2011-06-14 00:59:26 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698