Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 7147011: Merge 88331 - 2011-06-07 Andrey Kosyakov <caseq@chromium.org> (Closed)

Created:
9 years, 6 months ago by loislo
Modified:
9 years, 6 months ago
Reviewers:
loislo
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/782/
Visibility:
Public.

Description

Merge 88331 - 2011-06-07 Andrey Kosyakov <caseq@chromium.org>; Reviewed by Pavel Feldman. Web Inspector: remove shadow dom inspection from Elements panel by default. https://bugs.webkit.org/show_bug.cgi?id=62188 This reverts r85751 * dom/Element.cpp: (WebCore::Element::ensureShadowRoot): (WebCore::Element::removeShadowRoot): * inspector/Inspector.json: * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): * inspector/InspectorDOMAgent.h: * inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMAgent.prototype._bindNodes): (WebInspector.DOMAgent.prototype.querySelectorAll): (WebInspector.DOMDispatcher.prototype.searchResults): * inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._attributesUpdated): (WebInspector.ElementsPanel.prototype._characterDataModified): (WebInspector.ElementsPanel.prototype._nodeInserted): (WebInspector.ElementsPanel.prototype._nodeRemoved): (WebInspector.ElementsPanel.prototype.updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumb): * inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): (): * inspector/front-end/inspector.css: * inspector/front-end/utilities.js: (Element.prototype.query): 2011-06-07 Andrey Kosyakov <caseq@chromium.org>; Reviewed by Pavel Feldman. Web Inspector: remove shadow dom inspection from Elements panel by default. https://bugs.webkit.org/show_bug.cgi?id=62188 This reverts r85751 * http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.findNode.processChildren): (initialize_ElementTest.InspectorTest.findNode.documentRequested): (initialize_ElementTest.InspectorTest.findNode): * inspector/console/console-shadow-dom-access.html: Removed. * inspector/elements/shadow-dom-expected.txt: Removed. * inspector/elements/shadow-dom.html: Removed. * platform/win/Skipped: TBR=caseq@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -275 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 2 chunks +1 line, -5 lines 0 comments Download
D LayoutTests/inspector/console/console-shadow-dom-access.html View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/inspector/elements/shadow-dom.html View 1 chunk +0 lines, -70 lines 0 comments Download
D LayoutTests/inspector/elements/shadow-dom-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
M LayoutTests/platform/win/Skipped View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/dom/Element.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/inspector/Inspector.json View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/WebCore/inspector/InspectorDOMAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/inspector/InspectorDOMAgent.cpp View 9 chunks +5 lines, -25 lines 0 comments Download
M Source/WebCore/inspector/front-end/DOMAgent.js View 8 chunks +1 line, -40 lines 0 comments Download
M Source/WebCore/inspector/front-end/ElementsPanel.js View 4 chunks +22 lines, -18 lines 0 comments Download
M Source/WebCore/inspector/front-end/ElementsTreeOutline.js View 8 chunks +7 lines, -25 lines 0 comments Download
M Source/WebCore/inspector/front-end/inspector.css View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/WebCore/inspector/front-end/utilities.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
loislo
9 years, 6 months ago (2011-06-14 07:28:17 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698