Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 714693002: Don't require getPropertyCSSValue in fast/css tests (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Don't require getPropertyCSSValue in fast/css tests As getPropertyCSSValue is no longer web-exposed we shouldn't require it in tests so we can delete the interface. BUG=428595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185111

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -166 lines) Patch
M LayoutTests/fast/css/custom-font-xheight.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/css/image-set-parsing-expected.txt View 1 2 1 chunk +18 lines, -75 lines 0 comments Download
M LayoutTests/fast/css/image-set-parsing-invalid-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/css/script-tests/image-set-parsing.js View 1 1 chunk +15 lines, -70 lines 0 comments Download
M LayoutTests/fast/css/script-tests/image-set-parsing-invalid.js View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/css/sheet-collection-link.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/style-enumerate-properties.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/style-enumerate-properties-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
6 years, 1 month ago (2014-11-10 18:51:52 UTC) #2
alancutter (OOO until 2018)
lgtm
6 years, 1 month ago (2014-11-11 08:45:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714693002/40001
6 years, 1 month ago (2014-11-11 08:45:31 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 08:47:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 185111

Powered by Google App Engine
This is Rietveld 408576698