chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java - Issue 714643002: Pause EME player whose external surface is stolen by another player

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java

Issue 714643002: Pause EME player whose external surface is stolen by another player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/native/external_video_surface_container_impl.cc ('k') | chromecast/browser/android/external_video_surface_container_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java

diff --git a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java

index 59d2c8f6d4d3a473f4fc96c1247a969f7043f71c..31e3b4f35ae48b5c65d4936ad8790b0627d7d55c 100644

--- a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java

+++ b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java

@@ -129,6 +129,8 @@ public class ExternalVideoSurfaceContainer implements SurfaceHolder.Callback {

@CalledByNative

protected void requestExternalVideoSurface(int playerId) {

+ assert playerId != INVALID_PLAYER_ID;

if (mPlayerId == playerId) return;

setActiveContainer(this);

@@ -140,6 +142,14 @@ public class ExternalVideoSurfaceContainer implements SurfaceHolder.Callback {

}

/**

+ * Returns id of player currently using the external video surface.

+ */

+ @CalledByNative

+ protected int getCurrentPlayerId() {

+ return mPlayerId;

+ }

+ /**

* Called when a media player wants to release an external video surface.

* @param playerId The ID of the media player.