Issue 71463003: "Fix" another crash in DeferredCanvasTest on valgrind bot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 71463003: "Fix" another crash in DeferredCanvasTest on valgrind bot (Closed)

Created:
7 years, 1 month ago by robertphillips

Modified:
7 years, 1 month ago

Reviewers:
jvanverth1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This fixes the following issue on the valgrind bot: Process terminating with default action of signal 11 (SIGSEGV) Access not within mapped region at address 0x18 at 0x581A13: SkSurface::getCanvas() (SkSurface_Base.h:75) by 0x426CAC: getSurfacePixelPtr(SkSurface*, bool) (DeferredCanvasTest.cpp:690) by 0x42C62A: TestDeferredCanvasSetSurface(skiatest::Reporter*, GrContextFactory*) (DeferredCanvasTest.cpp:793) by 0x42D46E: skiatest::TestDeferredCanvasClass::onRun(skiatest::Reporter*) (DeferredCanvasTest.cpp:847) by 0x49670A: skiatest::Test::run() (Test.cpp:109) by 0x48FDA0: SkTestRunnable::run() (skia_test.cpp:155) by 0x48F746: tool_main(int, char**) (skia_test.cpp:246) by 0x48F922: main (skia_test.cpp:276)

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tests/DeferredCanvasTest.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

committed as r12265

Expand Messages | Collapse Messages