Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 714573002: Delete mojob.sh which is superseded by mojob.py (Closed)

Created:
6 years, 1 month ago by jam
Modified:
6 years, 1 month ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -277 lines) Patch
M README.md View 1 1 chunk +1 line, -1 line 0 comments Download
D mojo/tools/mojob.sh View 1 2 1 chunk +9 lines, -276 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jam
6 years, 1 month ago (2014-11-10 15:09:37 UTC) #2
jamesr
Can we make the shell script just call into python ala https://code.google.com/p/chromium/codesearch#chromium/src/tools/git/mass-rename.sh&q=mass-rename.sh&sq=package:chromium&l=11 and many other ...
6 years, 1 month ago (2014-11-10 18:41:55 UTC) #3
jam
Updated the shell script to call into python temporarily and with a message saying it's ...
6 years, 1 month ago (2014-11-10 19:29:49 UTC) #4
jamesr
lgtm
6 years, 1 month ago (2014-11-10 19:31:28 UTC) #5
jam
6 years, 1 month ago (2014-11-10 20:04:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6d1ef8a3c58d10b5e4bb56b3197f48f1d4e83270.

Powered by Google App Engine
This is Rietveld 408576698