Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 714533002: Small refactoring of layer discovery code (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Small refactoring of layer discovery code This CL removes CollectLayers' reliance on having the top most picture (by removing the unused fPictureID member). This then allows making CollectLayers' API closer to that of SkRecordFillBounds in order to facilitate using them interchangeably. Committed: https://skia.googlesource.com/skia/+/6beeb8f3cc323dabed0905920a336ed77aa5c46d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M include/core/SkPicture.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrPictureUtils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrPictureUtils.cpp View 6 chunks +21 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
robertphillips
6 years, 1 month ago (2014-11-09 16:51:43 UTC) #2
bsalomon
lgtm
6 years, 1 month ago (2014-11-10 16:03:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714533002/1
6 years, 1 month ago (2014-11-10 16:03:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/743)
6 years, 1 month ago (2014-11-10 16:27:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714533002/1
6 years, 1 month ago (2014-11-10 16:44:59 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 16:48:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6beeb8f3cc323dabed0905920a336ed77aa5c46d

Powered by Google App Engine
This is Rietveld 408576698