Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: tools/dom/src/native_DOMImplementation.dart

Issue 71453008: Remove use of deprecated mirror functions from Dartium's dart:html. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/dom/dom.json ('K') | « tools/dom/dom.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/src/native_DOMImplementation.dart
diff --git a/tools/dom/src/native_DOMImplementation.dart b/tools/dom/src/native_DOMImplementation.dart
index 43d542f8fe68b569add11d691992f67016feca1e..7d47bc984d5d7d7508cde9df87040d8b1dfbe0c8 100644
--- a/tools/dom/src/native_DOMImplementation.dart
+++ b/tools/dom/src/native_DOMImplementation.dart
@@ -302,7 +302,7 @@ class _Utils {
addForClass(ClassMirror mirror, bool isStatic) {
if (mirror == null)
return;
- addAll(mirror.members, isStatic);
+ addAll(mirror.declarations, isStatic);
if (mirror.superclass != null)
addForClass(mirror.superclass, isStatic);
for (var interface in mirror.superinterfaces) {
@@ -423,7 +423,9 @@ class _Utils {
}
var className = MirrorSystem.getName(cls.simpleName);
var createdConstructor = cls.constructors[new Symbol('$className.created')];
- if (createdConstructor == null) {
+ if (createdConstructor == null ||
+ createdConstructor is! MethodMirror ||
+ !createdConstructor.isConstructor) {
throw new UnsupportedError(
'Class is missing constructor $className.created');
}
« tools/dom/dom.json ('K') | « tools/dom/dom.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698