Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 714483002: Revert of PPAPI: Make GetProxiedInterface not re-enter the plugin (Closed)

Created:
6 years, 1 month ago by kareng
Modified:
6 years, 1 month ago
CC:
chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of PPAPI: Make GetProxiedInterface not re-enter the plugin (patchset #2 id:20001 of https://codereview.chromium.org/704913002/) Reason for revert: reverted due to 431529 Original issue's description: > PPAPI: Make GetProxiedInterface not re-enter the plugin > > It's important that we never re-enter the plugin when it is blocked on > synchronous calls to the renderer (unless they are scripting messages, which > have to be re-entrant). This especially breaks assumptions in OpenGL usage. > > This required making the plugin side of the PPB_VideoDecoder_Dev proxy check > for the interface prior to sending its synchronous Create message. I audited > all the other uses of GetProxiedInterface from the renderer, and none of the > others happen as a result of a sync plugin->renderer message. > > I also renamed the existing "SupportsInterface" message to "IsInterfaceSupported" to make the intent more obvious, and because I liked the SupportsInterface name better for the new usage: Telling the renderer that an interface is supported. > > BUG=418651 > > Committed: https://crrev.com/a17de8faa97ca33d1e58e08392dbdc3e316d6cbe > Cr-Commit-Position: refs/heads/master@{#303247} TBR=teravest@chromium.org,tsepez@chromium.org,piman@chromium.org,dmichael@chromium.org NOTREECHECKS=true NOTRY=true BUG=418651 Committed: https://crrev.com/1c62eeb1968b8da5bd44fac51a66949d67a999cc Cr-Commit-Position: refs/heads/master@{#303388}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -36 lines) Patch
M ppapi/proxy/host_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/host_dispatcher.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 2 chunks +4 lines, -8 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kareng
Created Revert of PPAPI: Make GetProxiedInterface not re-enter the plugin
6 years, 1 month ago (2014-11-08 16:34:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714483002/1
6 years, 1 month ago (2014-11-08 16:34:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-08 16:35:12 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 16:35:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c62eeb1968b8da5bd44fac51a66949d67a999cc
Cr-Commit-Position: refs/heads/master@{#303388}

Powered by Google App Engine
This is Rietveld 408576698