Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 714433002: mac: Switch from -O3 to -O2. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: Switch from -O3 to -O2. All other platforms use other -O2 or -Os. Since Linux even uses the same compiler as mac now, there isn't a great reason for Mac to use a different optimization level. In a static release build, this reduces binary size from 175.1MB to 174MB, so it's probalby not a huge change anyways. If it is, the perf bots will tell us. BUG=none Committed: https://crrev.com/9ce1b7510648285b80ff75213384bf4186b8c9dd Cr-Commit-Position: refs/heads/master@{#303476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
6 years, 1 month ago (2014-11-08 00:00:24 UTC) #2
Mark Mentovai
LGTM. -O3 was chosen with input from performance tests a long time ago on a ...
6 years, 1 month ago (2014-11-10 13:38:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714433002/1
6 years, 1 month ago (2014-11-10 15:19:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-10 16:19:47 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 17:12:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ce1b7510648285b80ff75213384bf4186b8c9dd
Cr-Commit-Position: refs/heads/master@{#303476}

Powered by Google App Engine
This is Rietveld 408576698