Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 714423005: DevTools: move front-end files from components to ui. (Closed)

Created:
6 years, 1 month ago by pfeldman
Modified:
6 years, 1 month ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: move front-end files from components to ui. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185209

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -5470 lines) Patch
M Source/devtools/devtools.gypi View 5 chunks +13 lines, -14 lines 0 comments Download
M Source/devtools/front_end/audits/AuditsPanel.js View 1 chunk +1 line, -1 line 0 comments Download
D Source/devtools/front_end/components/FilterBar.js View 1 chunk +0 lines, -768 lines 0 comments Download
D Source/devtools/front_end/components/FilterSuggestionBuilder.js View 1 chunk +0 lines, -205 lines 0 comments Download
D Source/devtools/front_end/components/FlameChart.js View 1 chunk +0 lines, -1319 lines 0 comments Download
D Source/devtools/front_end/components/HelpScreen.js View 1 chunk +0 lines, -154 lines 0 comments Download
D Source/devtools/front_end/components/OverviewGrid.js View 1 chunk +0 lines, -483 lines 0 comments Download
D Source/devtools/front_end/components/Panel.js View 1 chunk +0 lines, -260 lines 0 comments Download
D Source/devtools/front_end/components/PropertiesSection.js View 1 chunk +0 lines, -52 lines 0 comments Download
D Source/devtools/front_end/components/SearchableView.js View 1 chunk +0 lines, -709 lines 0 comments Download
D Source/devtools/front_end/components/Section.js View 1 chunk +0 lines, -220 lines 0 comments Download
D Source/devtools/front_end/components/TimelineGrid.js View 1 chunk +0 lines, -353 lines 0 comments Download
D Source/devtools/front_end/components/flameChart.css View 1 chunk +0 lines, -65 lines 0 comments Download
D Source/devtools/front_end/components/helpScreen.css View 1 chunk +0 lines, -644 lines 0 comments Download
M Source/devtools/front_end/components/module.json View 1 chunk +2 lines, -16 lines 0 comments Download
D Source/devtools/front_end/components/overviewGrid.css View 1 chunk +0 lines, -62 lines 0 comments Download
D Source/devtools/front_end/components/panelEnablerView.css View 1 chunk +0 lines, -109 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 chunk +36 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/RenderingOptions.js View 1 chunk +1 line, -1 line 0 comments Download
A + Source/devtools/front_end/network/FilterSuggestionBuilder.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/devtools/front_end/network/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
A + Source/devtools/front_end/ui/FilterBar.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/devtools/front_end/ui/FlameChart.js View 1 chunk +1 line, -1 line 0 comments Download
A + Source/devtools/front_end/ui/HelpScreen.js View 3 chunks +2 lines, -39 lines 0 comments Download
A + Source/devtools/front_end/ui/OverviewGrid.js View 1 chunk +1 line, -1 line 0 comments Download
A + Source/devtools/front_end/ui/Panel.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/devtools/front_end/ui/SearchableView.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/devtools/front_end/ui/Section.js View 1 chunk +24 lines, -0 lines 0 comments Download
A + Source/devtools/front_end/ui/TimelineGrid.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/devtools/front_end/ui/flameChart.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/devtools/front_end/ui/helpScreen.css View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/devtools/front_end/ui/module.json View 3 chunks +14 lines, -2 lines 0 comments Download
A + Source/devtools/front_end/ui/overviewGrid.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/devtools/front_end/ui/panelEnablerView.css View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pfeldman
6 years, 1 month ago (2014-11-12 13:08:47 UTC) #2
apavlov
lgtm with a comment https://codereview.chromium.org/714423005/diff/1/Source/devtools/front_end/ui/PropertiesSection.js File Source/devtools/front_end/ui/PropertiesSection.js (right): https://codereview.chromium.org/714423005/diff/1/Source/devtools/front_end/ui/PropertiesSection.js#newcode1 Source/devtools/front_end/ui/PropertiesSection.js:1: /* Please delete the file.
6 years, 1 month ago (2014-11-12 13:25:58 UTC) #3
pfeldman
https://codereview.chromium.org/714423005/diff/1/Source/devtools/front_end/ui/PropertiesSection.js File Source/devtools/front_end/ui/PropertiesSection.js (right): https://codereview.chromium.org/714423005/diff/1/Source/devtools/front_end/ui/PropertiesSection.js#newcode1 Source/devtools/front_end/ui/PropertiesSection.js:1: /* On 2014/11/12 13:25:57, apavlov wrote: > Please delete ...
6 years, 1 month ago (2014-11-12 13:30:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714423005/20001
6 years, 1 month ago (2014-11-12 13:30:46 UTC) #6
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
6 years, 1 month ago (2014-11-12 13:31:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714423005/20001
6 years, 1 month ago (2014-11-12 13:32:00 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 14:37:26 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185209

Powered by Google App Engine
This is Rietveld 408576698