Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 714413006: Cleanup: Organize GetWebUIFactoryFunction(). (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
6 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Organize GetWebUIFactoryFunction(). Committed: https://crrev.com/244890307e463102afe13d7cf7c4e01b6b7ebb26 Cr-Commit-Position: refs/heads/master@{#304937}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : address comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -75 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 9 chunks +69 lines, -75 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Lei Zhang
6 years, 1 month ago (2014-11-12 21:35:12 UTC) #4
Dan Beam
how is this code better?
6 years, 1 month ago (2014-11-12 21:39:30 UTC) #5
Lei Zhang
See the big comment blocks that define what each section is for.
6 years, 1 month ago (2014-11-12 21:41:48 UTC) #6
Lei Zhang
ping
6 years, 1 month ago (2014-11-19 19:45:16 UTC) #7
Dan Beam
https://codereview.chromium.org/714413006/diff/40001/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right): https://codereview.chromium.org/714413006/diff/40001/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc#newcode494 chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:494: return &NewWebUI<AboutUI>; why is this here? why not after ...
6 years, 1 month ago (2014-11-19 20:10:00 UTC) #8
Lei Zhang
https://codereview.chromium.org/714413006/diff/40001/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right): https://codereview.chromium.org/714413006/diff/40001/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc#newcode494 chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:494: return &NewWebUI<AboutUI>; On 2014/11/19 20:10:00, Dan Beam wrote: > ...
6 years, 1 month ago (2014-11-19 20:17:56 UTC) #9
Dan Beam
lgtm
6 years, 1 month ago (2014-11-19 23:17:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714413006/80001
6 years, 1 month ago (2014-11-19 23:22:53 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:80001)
6 years, 1 month ago (2014-11-20 00:12:15 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 00:13:07 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/244890307e463102afe13d7cf7c4e01b6b7ebb26
Cr-Commit-Position: refs/heads/master@{#304937}

Powered by Google App Engine
This is Rietveld 408576698