Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 714413004: [turbofan] More useful typing for And, Or and Shr. (Closed)

Created:
6 years, 1 month ago by Jarin
Modified:
6 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] More useful typing for And, Or and Shr. BUG= Committed: https://chromium.googlesource.com/v8/v8/+/3312ea233923d78713289af56f9c3e5c21677178

Patch Set 1 #

Patch Set 2 : Update tests #

Patch Set 3 : Run the typer for change lowering cctests. #

Patch Set 4 : Minor tweak for bitwise or. #

Patch Set 5 : Fix the range/bitset subtyping mess-up in bitwise or. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -22 lines) Patch
M src/compiler/change-lowering.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 2 3 4 3 chunks +49 lines, -22 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Benedikt Meurer
LGTM, nice.
6 years, 1 month ago (2014-11-17 12:15:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714413004/80001
6 years, 1 month ago (2014-11-17 13:27:34 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 13:55:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:80001)

Powered by Google App Engine
This is Rietveld 408576698