Issue 7144015: Change age-mark to not expect pages to be in increasing order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7144015: Change age-mark to not expect pages to be in increasing order. (Closed)

Created:
9 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Description

Change age-mark to not expect pages to be in increasing order. Committed: http://code.google.com/p/v8/source/detail?r=8278

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment #

Patch Set 3 : And move logical operators #

Patch Set 4 : Fix bug in assert. Move some functions. #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -70 lines)			Patch
M	src/heap-inl.h	View	1 2	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/spaces.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/spaces.cc	View	1 2 3	4 chunks	+77 lines, -66 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

Although I'm beginning to think it would be better handle this in the outer loop ...

9 years, 6 months ago (2011-06-14 12:04:11 UTC) #1

Vyacheslav Egorov (Chromium)

9 years, 6 months ago (2011-06-14 12:12:46 UTC) #2

LGTM

http://codereview.chromium.org/7144015/diff/1/src/heap-inl.h
File src/heap-inl.h (right):

http://codereview.chromium.org/7144015/diff/1/src/heap-inl.h#newcode304
src/heap-inl.h:304: // TODO(gc): Do something about age-mark in paged new-space.
You can remove this todo.

http://codereview.chromium.org/7144015/diff/1/src/heap-inl.h#newcode310
src/heap-inl.h:310: || (new_space_.Size() + object_size) >=
(new_space_.Capacity() >> 2);
move || to the end of the previous line

Expand Messages | Collapse Messages