Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 71433002: Enable XHR upload progress events for Workers. (Closed)

Created:
7 years, 1 month ago by sof
Modified:
7 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Enable XHR upload progress events for Workers. The request flag recording progress event reporting wasn't been copied out of the worker when creating the loader on the main thread. Do so to have upload progress events be reported over XMLHttpRequest inside a Worker. R= BUG=173658 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161923

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add missing doctype declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -4 lines) Patch
A + LayoutTests/http/tests/xmlhttprequest/workers/resources/upload-onprogress-event.js View 1 chunk +7 lines, -4 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/workers/resources/upload-onprogress-worker.js View 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/workers/upload-onprogress-event.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/workers/upload-onprogress-event-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceRequest.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/network/ResourceRequest.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sof
At your leisure, please take a look. (If there are reviewers even better suited, please ...
7 years, 1 month ago (2013-11-13 11:13:16 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/71433002/diff/1/LayoutTests/http/tests/xmlhttprequest/workers/upload-onprogress-event.html File LayoutTests/http/tests/xmlhttprequest/workers/upload-onprogress-event.html (right): https://codereview.chromium.org/71433002/diff/1/LayoutTests/http/tests/xmlhttprequest/workers/upload-onprogress-event.html#newcode1 LayoutTests/http/tests/xmlhttprequest/workers/upload-onprogress-event.html:1: <html> <!doctype html>
7 years, 1 month ago (2013-11-13 11:45:36 UTC) #2
sof
Thanks jochen; will remember to supply those from now on. https://codereview.chromium.org/71433002/diff/1/LayoutTests/http/tests/xmlhttprequest/workers/upload-onprogress-event.html File LayoutTests/http/tests/xmlhttprequest/workers/upload-onprogress-event.html (right): https://codereview.chromium.org/71433002/diff/1/LayoutTests/http/tests/xmlhttprequest/workers/upload-onprogress-event.html#newcode1 ...
7 years, 1 month ago (2013-11-13 11:53:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/71433002/60001
7 years, 1 month ago (2013-11-13 11:54:56 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=12378
7 years, 1 month ago (2013-11-13 13:33:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/71433002/60001
7 years, 1 month ago (2013-11-13 14:16:26 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 15:09:22 UTC) #7
Message was sent while issue was closed. 
Change committed as 161923

Powered by Google App Engine
This is Rietveld 408576698