Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: tools/perf/measurements/webrtc.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Add a common subclass to measurements. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/webrtc.py
diff --git a/tools/perf/measurements/webrtc.py b/tools/perf/measurements/webrtc.py
index 5b8680ba3ae1a41ecbaed0a6e05114d473f5a5fa..ad37be04a4da964ceb11305c04ab48ebd789e01e 100644
--- a/tools/perf/measurements/webrtc.py
+++ b/tools/perf/measurements/webrtc.py
@@ -2,14 +2,14 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+from measurements import PageTestMeasurement
from metrics import cpu
from metrics import memory
from metrics import power
from metrics import webrtc_stats
-from telemetry.page import page_test
-class WebRTC(page_test.PageTest):
+class WebRTC(PageTestMeasurement):
"""Gathers WebRTC-related metrics on a page set."""
def __init__(self):
@@ -34,6 +34,7 @@ class WebRTC(page_test.PageTest):
self._webrtc_stats_metric.Start(page, tab)
def CustomizeBrowserOptions(self, options):
+ super(WebRTC, self).CustomizeBrowserOptions(options)
memory.MemoryMetric.CustomizeBrowserOptions(options)
options.AppendExtraBrowserArgs('--use-fake-device-for-media-stream')
options.AppendExtraBrowserArgs('--use-fake-ui-for-media-stream')
@@ -41,6 +42,8 @@ class WebRTC(page_test.PageTest):
def ValidateAndMeasurePage(self, page, tab, results):
"""Measure the page's performance."""
+ super(WebRTC, self).ValidateAndMeasurePage(page, tab, results)
+
self._memory_metric.Stop(page, tab)
self._memory_metric.AddResults(tab, results)

Powered by Google App Engine
This is Rietveld 408576698