Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: tools/perf/measurements/startup.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Add a common subclass to measurements. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/startup.py
diff --git a/tools/perf/measurements/startup.py b/tools/perf/measurements/startup.py
index 6d26ee92a1a1b00e43ea42752d15bb2a18366dd9..a65ea9efb240f71633ac77f38ad8749f2b1dc55c 100644
--- a/tools/perf/measurements/startup.py
+++ b/tools/perf/measurements/startup.py
@@ -2,11 +2,11 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+from measurements import PageTestMeasurement
from metrics import startup_metric
-from telemetry.page import page_test
-class Startup(page_test.PageTest):
+class Startup(PageTestMeasurement):
"""Performs a measurement of Chromium's startup performance.
This test must be invoked with either --warm or --cold on the command line. A
@@ -35,6 +35,7 @@ class Startup(page_test.PageTest):
# parser.error('You must specify either --warm or --cold')
def CustomizeBrowserOptions(self, options):
+ super(Startup, self).CustomizeBrowserOptions(options)
if self._cold:
options.clear_sytem_cache_for_browser_and_profile_on_start = True
else:
@@ -49,6 +50,7 @@ class Startup(page_test.PageTest):
pass
def ValidateAndMeasurePage(self, page, tab, results):
+ super(Startup, self).ValidateAndMeasurePage(page, tab, results)
startup_metric.StartupMetric().AddResults(tab, results)

Powered by Google App Engine
This is Rietveld 408576698