Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/perf/measurements/skpicture_printer.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Add a common subclass to measurements. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/skpicture_printer.py
diff --git a/tools/perf/measurements/skpicture_printer.py b/tools/perf/measurements/skpicture_printer.py
index 687cf0cd4d7caa1cc73c5b7bdd7337ffa115ad06..afcb55d8898830ff15a10e12bca215312688eeda 100644
--- a/tools/perf/measurements/skpicture_printer.py
+++ b/tools/perf/measurements/skpicture_printer.py
@@ -4,6 +4,7 @@
import glob
import os
+from measurements import PageTestMeasurement
from telemetry.page import page_test
from telemetry.value import scalar
@@ -11,7 +12,7 @@ from telemetry.value import scalar
_JS = 'chrome.gpuBenchmarking.printToSkPicture("{0}");'
-class SkpicturePrinter(page_test.PageTest):
+class SkpicturePrinter(PageTestMeasurement):
@classmethod
def AddCommandLineArgs(cls, parser):
parser.add_option('-s', '--skp-outdir',
@@ -24,6 +25,7 @@ class SkpicturePrinter(page_test.PageTest):
cls._skp_outdir = args.skp_outdir
def CustomizeBrowserOptions(self, options):
+ super(SkpicturePrinter, self).CustomizeBrowserOptions(options)
options.AppendExtraBrowserArgs(['--enable-gpu-benchmarking',
'--no-sandbox',
'--enable-deferred-image-decoding'])
@@ -41,3 +43,5 @@ class SkpicturePrinter(page_test.PageTest):
pictures = glob.glob(os.path.join(outpath, '*.skp'))
results.AddValue(scalar.ScalarValue(
results.current_page, 'saved_picture_count', 'count', len(pictures)))
+
+ super(SkpicturePrinter, self).ValidateAndMeasurePage(page, tab, results)

Powered by Google App Engine
This is Rietveld 408576698