tools/perf/measurements/screenshot.py - Issue 714273004: mac: Expose keychain access frequency to Telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/screenshot.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep

Patch Set: Add a common subclass to measurements. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/screenshot.py

diff --git a/tools/perf/measurements/screenshot.py b/tools/perf/measurements/screenshot.py

index 8564c8a473236a06435c33aaef30ee18a4521a9e..7b8877211b5b6d2fff77862662047596e37b9942 100644

--- a/tools/perf/measurements/screenshot.py

+++ b/tools/perf/measurements/screenshot.py

@@ -3,12 +3,12 @@

# found in the LICENSE file.

import os

-from telemetry.page import page_test

+from measurements import PageTestMeasurement

from telemetry.page import page_test

from telemetry.value import scalar

-class Screenshot(page_test.PageTest):

+class Screenshot(PageTestMeasurement):

def __init__(self):

super(Screenshot, self).__init__(

action_name_to_run = 'RunPageInteractions',

@@ -49,3 +49,5 @@ class Screenshot(page_test.PageTest):

results.AddValue(scalar.ScalarValue(

results.current_page, 'saved_picture_count', 'count',

saved_picture_count))

+ super(Screenshot, self).ValidateAndMeasurePage(page, tab, results)

« tools/perf/measurements/__init__.py ('K') | « tools/perf/measurements/repaint.py ('k') | tools/perf/measurements/session_restore.py » ('j') | tools/perf/metrics/keychain_metric.py » ('J')