Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: tools/perf/measurements/record_per_area.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Add a common subclass to measurements. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/record_per_area.py
diff --git a/tools/perf/measurements/record_per_area.py b/tools/perf/measurements/record_per_area.py
index 0804addd1e91476204405d29c3cc8af4603dbee3..0ba0b92f3771d1d74097324e8801c6d4af8c0593 100644
--- a/tools/perf/measurements/record_per_area.py
+++ b/tools/perf/measurements/record_per_area.py
@@ -4,12 +4,12 @@
import time
+from measurements import PageTestMeasurement
from measurements import smoothness
-from telemetry.page import page_test
from telemetry.value import scalar
-class RecordPerArea(page_test.PageTest):
+class RecordPerArea(PageTestMeasurement):
def __init__(self):
super(RecordPerArea, self).__init__('', True)
@@ -20,7 +20,8 @@ class RecordPerArea(page_test.PageTest):
'(must be long enought to load all content)')
def CustomizeBrowserOptions(self, options):
- smoothness.Smoothness.CustomizeBrowserOptions(options)
+ super(RecordPerArea, self).CustomizeBrowserOptions(options)
+ smoothness.Smoothness.CustomizeBrowserOptionsClass(options)
options.AppendExtraBrowserArgs([
'--enable-impl-side-painting',
'--enable-threaded-compositing',
@@ -32,6 +33,8 @@ class RecordPerArea(page_test.PageTest):
# Needs to be adjusted for every device (~2 seconds for workstation).
time.sleep(self.options.start_wait_time)
+ super(RecordPerArea, self).ValidateAndMeasurePage(page, tab, results)
+
# Enqueue benchmark
tab.ExecuteJavaScript("""
window.benchmark_results = {};

Powered by Google App Engine
This is Rietveld 408576698