Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: tools/perf/measurements/media.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Add a common subclass to measurements. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/media.py
diff --git a/tools/perf/measurements/media.py b/tools/perf/measurements/media.py
index 2e58ed7cedff0933b3a4aaa22655b25cbf2590c1..a60b0eb1702a158cd2445d5391f254e0f38ab8fc 100644
--- a/tools/perf/measurements/media.py
+++ b/tools/perf/measurements/media.py
@@ -2,14 +2,14 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+from measurements import PageTestMeasurement
from metrics import cpu
from metrics import media
from metrics import system_memory
from metrics import power
-from telemetry.page import page_test
-class Media(page_test.PageTest):
+class Media(PageTestMeasurement):
"""The MediaMeasurement class gathers media-related metrics on a page set.
Media metrics recorded are controlled by metrics/media.js. At the end of the
@@ -30,6 +30,7 @@ class Media(page_test.PageTest):
def CustomizeBrowserOptions(self, options):
# Needed to run media actions in JS on touch-based devices as on Android.
+ super(Media, self).CustomizeBrowserOptions(options)
options.AppendExtraBrowserArgs(
'--disable-gesture-requirement-for-media-playback')
power.PowerMetric.CustomizeBrowserOptions(options)
@@ -52,6 +53,7 @@ class Media(page_test.PageTest):
def ValidateAndMeasurePage(self, page, tab, results):
"""Measure the page's performance."""
+ super(Media, self).ValidateAndMeasurePage(page, tab, results)
self._media_metric.Stop(page, tab)
trace_name = self._media_metric.AddResults(tab, results)

Powered by Google App Engine
This is Rietveld 408576698