Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2788)

Unified Diff: tools/perf/benchmarks/sunspider.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Add a common subclass to measurements. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/sunspider.py
diff --git a/tools/perf/benchmarks/sunspider.py b/tools/perf/benchmarks/sunspider.py
index ab1c2dd675c4cfc770e904adcee9b53ca58579d5..2a454b40761ff40e73235820b16b92ebd40e10be 100644
--- a/tools/perf/benchmarks/sunspider.py
+++ b/tools/perf/benchmarks/sunspider.py
@@ -5,10 +5,10 @@ import collections
import json
import os
+from measurements import PageTestMeasurement
from metrics import power
from telemetry import benchmark
from telemetry.page import page_set
-from telemetry.page import page_test
from telemetry.value import list_of_scalar_values
@@ -72,12 +72,13 @@ DESCRIPTIONS = {
}
-class _SunspiderMeasurement(page_test.PageTest):
+class _SunspiderMeasurement(PageTestMeasurement):
def __init__(self):
super(_SunspiderMeasurement, self).__init__()
self._power_metric = None
def CustomizeBrowserOptions(self, options):
+ super(_SunspiderMeasurement, self).CustomizeBrowserOptions(options)
power.PowerMetric.CustomizeBrowserOptions(options)
def WillStartBrowser(self, platform):
@@ -121,6 +122,8 @@ class _SunspiderMeasurement(page_test.PageTest):
results.current_page, 'Total', 'ms', totals,
description='Totals of run time for each different type of benchmark '
'in sunspider'))
+ super(_SunspiderMeasurement, self).ValidateAndMeasurePage(
+ page, tab, results)
class Sunspider(benchmark.Benchmark):

Powered by Google App Engine
This is Rietveld 408576698