Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1461)

Unified Diff: tools/perf/benchmarks/spaceport.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Add a common subclass to measurements. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/spaceport.py
diff --git a/tools/perf/benchmarks/spaceport.py b/tools/perf/benchmarks/spaceport.py
index 21273ec5da736906b223316a6afb2ec45b7543c4..fc7487ef4fd1467867799c2bb074d2c81063e304 100644
--- a/tools/perf/benchmarks/spaceport.py
+++ b/tools/perf/benchmarks/spaceport.py
@@ -7,10 +7,10 @@
import logging
import os
+from measurements import PageTestMeasurement
from telemetry import benchmark
from telemetry.core import util
from telemetry.page import page_set
-from telemetry.page import page_test
from telemetry.value import list_of_scalar_values
from telemetry.value import scalar
@@ -46,11 +46,12 @@ DESCRIPTIONS = {
}
-class _SpaceportMeasurement(page_test.PageTest):
+class _SpaceportMeasurement(PageTestMeasurement):
def __init__(self):
super(_SpaceportMeasurement, self).__init__()
def CustomizeBrowserOptions(self, options):
+ super(_SpaceportMeasurement, self).CustomizeBrowserOptions(options)
options.AppendExtraBrowserArgs('--disable-gpu-vsync')
def ValidateAndMeasurePage(self, page, tab, results):
@@ -90,6 +91,8 @@ class _SpaceportMeasurement(page_test.PageTest):
results.current_page, 'Score', 'objects (bigger is better)',
[float(x) for x in result_dict.values()],
description='Combined score for all parts of the spaceport benchmark.'))
+ super(_SpaceportMeasurement, self).ValidateAndMeasurePage(
+ page, tab, results)
# crbug.com/166703: This test frequently times out on Windows.

Powered by Google App Engine
This is Rietveld 408576698