Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: tools/perf/benchmarks/maps.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Add a common subclass to measurements. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/maps.py
diff --git a/tools/perf/benchmarks/maps.py b/tools/perf/benchmarks/maps.py
index efc42dd67aa50e16664231fddbd1f97727bbedde..ed39d55c7cf1679e308695fdd8ff3521610bbf01 100644
--- a/tools/perf/benchmarks/maps.py
+++ b/tools/perf/benchmarks/maps.py
@@ -8,15 +8,15 @@ Rerforms several common navigation actions on the map (pan, zoom, rotate)"""
import os
import re
+from measurements import PageTestMeasurement
from telemetry import benchmark
from telemetry.core import util
from telemetry.page import page as page_module
from telemetry.page import page_set as page_set_module
-from telemetry.page import page_test
from telemetry.value import scalar
-class _MapsMeasurement(page_test.PageTest):
+class _MapsMeasurement(PageTestMeasurement):
def ValidateAndMeasurePage(self, page, tab, results):
js_get_results = 'document.getElementsByTagName("pre")[0].innerText'
test_results = tab.EvaluateJavaScript(js_get_results)
@@ -27,6 +27,7 @@ class _MapsMeasurement(page_test.PageTest):
results.current_page, 'total_time', 'ms', total))
results.AddValue(scalar.ScalarValue(
results.current_page, 'render_mean_time', 'ms', render))
+ super(_MapsMeasurement, self).ValidateAndMeasurePage(page, tab, results)
class MapsPage(page_module.Page):
def __init__(self, page_set, base_dir):

Powered by Google App Engine
This is Rietveld 408576698