Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: tools/perf/benchmarks/jsgamebench.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Add a common subclass to measurements. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/jsgamebench.py
diff --git a/tools/perf/benchmarks/jsgamebench.py b/tools/perf/benchmarks/jsgamebench.py
index a9c10f6a636a604917c05b5f4292505310361daf..3ec10280976c6deb79256852cf96ed0047fb7e56 100644
--- a/tools/perf/benchmarks/jsgamebench.py
+++ b/tools/perf/benchmarks/jsgamebench.py
@@ -12,13 +12,13 @@ The benchmark is kept here for historical purposes but is disabled on the bots.
import os
+from measurements import PageTestMeasurement
from telemetry import benchmark
from telemetry.page import page_set
-from telemetry.page import page_test
from telemetry.value import scalar
-class _JsgamebenchMeasurement(page_test.PageTest):
+class _JsgamebenchMeasurement(PageTestMeasurement):
def __init__(self):
super(_JsgamebenchMeasurement, self).__init__()
@@ -31,6 +31,8 @@ class _JsgamebenchMeasurement(page_test.PageTest):
result = int(tab.EvaluateJavaScript(js_get_results))
results.AddValue(scalar.ScalarValue(
results.current_page, 'Score', 'score (bigger is better)', result))
+ super(_JsgamebenchMeasurement, self).ValidateAndMeasurePage(
+ page, tab, results)
@benchmark.Disabled

Powered by Google App Engine
This is Rietveld 408576698