Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: tools/perf/measurements/page_cycler.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Comments from dtu. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/page_cycler.py
diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py
index 61991b0d87bf136c6fa05403a9ef6d0115c820cc..65a20ae2a3a30fa7ad9722ef4fe72a1ce308b278 100644
--- a/tools/perf/measurements/page_cycler.py
+++ b/tools/perf/measurements/page_cycler.py
@@ -19,6 +19,7 @@ import collections
import os
from metrics import cpu
+from metrics import keychain_metric
from metrics import memory
from metrics import power
from metrics import speedindex
@@ -111,6 +112,8 @@ class PageCycler(page_test.PageTest):
if self._report_speed_index:
self._speedindex_metric.CustomizeBrowserOptions(options)
+ keychain_metric.KeychainMetric.CustomizeBrowserOptionsMac(options)
+
def ValidateAndMeasurePage(self, page, tab, results):
tab.WaitForJavaScriptExpression('__pc_load_time', 60)
@@ -147,6 +150,7 @@ class PageCycler(page_test.PageTest):
self._speedindex_metric.Stop(page, tab)
self._speedindex_metric.AddResults(
tab, results, chart_name=chart_name_prefix+'speed_index')
+ keychain_metric.KeychainMetric().AddResultsMac(tab, results)
def IsRunCold(self, url):
return (self.ShouldRunCold(url) or

Powered by Google App Engine
This is Rietveld 408576698