components/os_crypt/os_crypt_mac.mm - Issue 714273004: mac: Expose keychain access frequency to Telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/os_crypt/os_crypt_mac.mm

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep

Patch Set: Comments from dtu. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/os_crypt/os_crypt_mac.mm

diff --git a/components/os_crypt/os_crypt_mac.mm b/components/os_crypt/os_crypt_mac.mm

index 507993196aeefde7c018114ef0e4951c9ed810d3..4248898f92a882b5d35f54e51f938f8ed7a82644 100644

--- a/components/os_crypt/os_crypt_mac.mm

+++ b/components/os_crypt/os_crypt_mac.mm

@@ -10,6 +10,7 @@

#include "base/debug/leak_annotations.h"

#include "base/logging.h"

#include "base/memory/scoped_ptr.h"

+#include "base/perf_util.h"

#include "base/strings/utf_string_conversions.h"

#include "base/synchronization/lock.h"

#include "components/os_crypt/keychain_password_mac.h"

@@ -57,6 +58,8 @@ crypto::SymmetricKey* GetEncryptionKey() {

std::string password;

if (use_mock_keychain || mock_keychain_command_line_flag) {

+ base::IncrementKeychainAccessHistogram();

password = "mock_password";

} else {

AppleKeychain keychain;

« base/perf_util.h ('K') | « base/perf_util.cc ('k') | crypto/mock_apple_keychain.cc » ('j') | tools/perf/measurements/page_cycler_unittest.py » ('J')