Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: tools/perf/benchmarks/speedometer.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Respond to offline comments from tonyg. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/speedometer.py
diff --git a/tools/perf/benchmarks/speedometer.py b/tools/perf/benchmarks/speedometer.py
index 639631c9c46039c8aa63870aba40a83e099f25cf..a9b1c61d4c0fae46a6568d7afb1aed99b6c7d1ea 100644
--- a/tools/perf/benchmarks/speedometer.py
+++ b/tools/perf/benchmarks/speedometer.py
@@ -18,6 +18,7 @@ engine, CSS style resolution, layout, and other technologies.
import os
+from metrics import keychain_metric
from telemetry import benchmark
from telemetry.page import page_set
from telemetry.page import page_test
@@ -35,6 +36,10 @@ class SpeedometerMeasurement(page_test.PageTest):
'FlightJS-TodoMVC'
]
+ def CustomizeBrowserOptions(self, options):
+ if keychain_metric.KeychainMetric.ShouldCollectKeychainMetrics():
+ keychain_metric.KeychainMetric.CustomizeBrowserOptions(options)
+
def ValidateAndMeasurePage(self, page, tab, results):
tab.WaitForDocumentReadyStateToBeComplete()
iterationCount = 10
@@ -71,6 +76,8 @@ class SpeedometerMeasurement(page_test.PageTest):
};
suite_times;
""" % suite_name), important=False))
+ if keychain_metric.KeychainMetric.ShouldCollectKeychainMetrics():
+ keychain_metric.KeychainMetric().AddResults(tab, results)
class Speedometer(benchmark.Benchmark):
test = SpeedometerMeasurement

Powered by Google App Engine
This is Rietveld 408576698