Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: tools/perf/measurements/page_cycler.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Comments from dtu. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2012 The Chromium Authors. All rights reserved. 1 # Copyright 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """The page cycler measurement. 5 """The page cycler measurement.
6 6
7 This measurement registers a window load handler in which is forces a layout and 7 This measurement registers a window load handler in which is forces a layout and
8 then records the value of performance.now(). This call to now() measures the 8 then records the value of performance.now(). This call to now() measures the
9 time from navigationStart (immediately after the previous page's beforeunload 9 time from navigationStart (immediately after the previous page's beforeunload
10 event) until after the layout in the page's load event. In addition, two garbage 10 event) until after the layout in the page's load event. In addition, two garbage
11 collections are performed in between the page loads (in the beforeunload event). 11 collections are performed in between the page loads (in the beforeunload event).
12 This extra garbage collection time is not included in the measurement times. 12 This extra garbage collection time is not included in the measurement times.
13 13
14 Finally, various memory and IO statistics are gathered at the very end of 14 Finally, various memory and IO statistics are gathered at the very end of
15 cycling all pages. 15 cycling all pages.
16 """ 16 """
17 17
18 import collections 18 import collections
19 import os 19 import os
20 20
21 from metrics import cpu 21 from metrics import cpu
22 from metrics import keychain_metric
22 from metrics import memory 23 from metrics import memory
23 from metrics import power 24 from metrics import power
24 from metrics import speedindex 25 from metrics import speedindex
25 from metrics import v8_object_stats 26 from metrics import v8_object_stats
26 from telemetry.core import util 27 from telemetry.core import util
27 from telemetry.page import page_test 28 from telemetry.page import page_test
28 from telemetry.value import scalar 29 from telemetry.value import scalar
29 30
30 31
31 class PageCycler(page_test.PageTest): 32 class PageCycler(page_test.PageTest):
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 def CustomizeBrowserOptions(self, options): 105 def CustomizeBrowserOptions(self, options):
105 memory.MemoryMetric.CustomizeBrowserOptions(options) 106 memory.MemoryMetric.CustomizeBrowserOptions(options)
106 power.PowerMetric.CustomizeBrowserOptions(options) 107 power.PowerMetric.CustomizeBrowserOptions(options)
107 options.AppendExtraBrowserArgs('--js-flags=--expose_gc') 108 options.AppendExtraBrowserArgs('--js-flags=--expose_gc')
108 109
109 if self._record_v8_object_stats: 110 if self._record_v8_object_stats:
110 v8_object_stats.V8ObjectStatsMetric.CustomizeBrowserOptions(options) 111 v8_object_stats.V8ObjectStatsMetric.CustomizeBrowserOptions(options)
111 if self._report_speed_index: 112 if self._report_speed_index:
112 self._speedindex_metric.CustomizeBrowserOptions(options) 113 self._speedindex_metric.CustomizeBrowserOptions(options)
113 114
115 keychain_metric.KeychainMetric.CustomizeBrowserOptionsMac(options)
116
114 def ValidateAndMeasurePage(self, page, tab, results): 117 def ValidateAndMeasurePage(self, page, tab, results):
115 tab.WaitForJavaScriptExpression('__pc_load_time', 60) 118 tab.WaitForJavaScriptExpression('__pc_load_time', 60)
116 119
117 chart_name_prefix = ('cold_' if self.IsRunCold(page.url) else 120 chart_name_prefix = ('cold_' if self.IsRunCold(page.url) else
118 'warm_') 121 'warm_')
119 122
120 results.AddValue(scalar.ScalarValue( 123 results.AddValue(scalar.ScalarValue(
121 results.current_page, '%stimes.page_load_time' % chart_name_prefix, 124 results.current_page, '%stimes.page_load_time' % chart_name_prefix,
122 'ms', tab.EvaluateJavaScript('__pc_load_time'), 125 'ms', tab.EvaluateJavaScript('__pc_load_time'),
123 description='Average page load time. Measured from ' 126 description='Average page load time. Measured from '
(...skipping 16 matching lines...) Expand all
140 self._v8_object_stats_metric.Stop(page, tab) 143 self._v8_object_stats_metric.Stop(page, tab)
141 self._v8_object_stats_metric.AddResults(tab, results) 144 self._v8_object_stats_metric.AddResults(tab, results)
142 145
143 if self._report_speed_index: 146 if self._report_speed_index:
144 def SpeedIndexIsFinished(): 147 def SpeedIndexIsFinished():
145 return self._speedindex_metric.IsFinished(tab) 148 return self._speedindex_metric.IsFinished(tab)
146 util.WaitFor(SpeedIndexIsFinished, 60) 149 util.WaitFor(SpeedIndexIsFinished, 60)
147 self._speedindex_metric.Stop(page, tab) 150 self._speedindex_metric.Stop(page, tab)
148 self._speedindex_metric.AddResults( 151 self._speedindex_metric.AddResults(
149 tab, results, chart_name=chart_name_prefix+'speed_index') 152 tab, results, chart_name=chart_name_prefix+'speed_index')
153 keychain_metric.KeychainMetric().AddResultsMac(tab, results)
150 154
151 def IsRunCold(self, url): 155 def IsRunCold(self, url):
152 return (self.ShouldRunCold(url) or 156 return (self.ShouldRunCold(url) or
153 self._has_loaded_page[url] == 0) 157 self._has_loaded_page[url] == 0)
154 158
155 def ShouldRunCold(self, url): 159 def ShouldRunCold(self, url):
156 # We do the warm runs first for two reasons. The first is so we can 160 # We do the warm runs first for two reasons. The first is so we can
157 # preserve any initial profile cache for as long as possible. 161 # preserve any initial profile cache for as long as possible.
158 # The second is that, if we did cold runs first, we'd have a transition 162 # The second is that, if we did cold runs first, we'd have a transition
159 # page set during which we wanted the run for each URL to both 163 # page set during which we wanted the run for each URL to both
160 # contribute to the cold data and warm the catch for the following 164 # contribute to the cold data and warm the catch for the following
161 # warm run, and clearing the cache before the load of the following 165 # warm run, and clearing the cache before the load of the following
162 # URL would eliminate the intended warmup for the previous URL. 166 # URL would eliminate the intended warmup for the previous URL.
163 return (self._has_loaded_page[url] >= self._cold_run_start_index) 167 return (self._has_loaded_page[url] >= self._cold_run_start_index)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698