Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: tools/perf/measurements/startup.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Respond to offline comments from tonyg. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from metrics import keychain_metric
5 from metrics import startup_metric 6 from metrics import startup_metric
6 from telemetry.page import page_test 7 from telemetry.page import page_test
7 8
8 9
9 class Startup(page_test.PageTest): 10 class Startup(page_test.PageTest):
10 """Performs a measurement of Chromium's startup performance. 11 """Performs a measurement of Chromium's startup performance.
11 12
12 Uses cold start if cold==True, otherwise uses warm start. A cold start means 13 Uses cold start if cold==True, otherwise uses warm start. A cold start means
13 none of the Chromium files are in the disk cache. A warm start assumes the OS 14 none of the Chromium files are in the disk cache. A warm start assumes the OS
14 has already cached much of Chromium's content. For warm tests, you should 15 has already cached much of Chromium's content. For warm tests, you should
15 repeat the page set to ensure it's cached. 16 repeat the page set to ensure it's cached.
16 """ 17 """
17 18
18 def __init__(self, cold=False, action_name_to_run=''): 19 def __init__(self, cold=False, action_name_to_run=''):
19 super(Startup, self).__init__(needs_browser_restart_after_each_page=True, 20 super(Startup, self).__init__(needs_browser_restart_after_each_page=True,
20 action_name_to_run=action_name_to_run) 21 action_name_to_run=action_name_to_run)
21 self._cold = cold 22 self._cold = cold
22 23
23 def CustomizeBrowserOptions(self, options): 24 def CustomizeBrowserOptions(self, options):
24 if self._cold: 25 if self._cold:
25 options.clear_sytem_cache_for_browser_and_profile_on_start = True 26 options.clear_sytem_cache_for_browser_and_profile_on_start = True
26 else: 27 else:
27 self.discard_first_result = True 28 self.discard_first_result = True
28 29
29 options.AppendExtraBrowserArgs([ 30 options.AppendExtraBrowserArgs([
30 '--enable-stats-collection-bindings' 31 '--enable-stats-collection-bindings'
31 ]) 32 ])
33 if keychain_metric.KeychainMetric.ShouldCollectKeychainMetrics():
34 keychain_metric.KeychainMetric.CustomizeBrowserOptions(options)
32 35
33 def RunNavigateSteps(self, page, tab): 36 def RunNavigateSteps(self, page, tab):
34 # Overriden so that no page navigation occurs - startup to the NTP. 37 # Overriden so that no page navigation occurs - startup to the NTP.
35 pass 38 pass
36 39
37 def ValidateAndMeasurePage(self, page, tab, results): 40 def ValidateAndMeasurePage(self, page, tab, results):
41 if keychain_metric.KeychainMetric.ShouldCollectKeychainMetrics():
42 keychain_metric.KeychainMetric().AddResults(tab, results)
38 startup_metric.StartupMetric().AddResults(tab, results) 43 startup_metric.StartupMetric().AddResults(tab, results)
39 44
40 45
41 class StartWithUrl(Startup): 46 class StartWithUrl(Startup):
42 """Performs a measurement of Chromium's performance starting with a URL. 47 """Performs a measurement of Chromium's performance starting with a URL.
43 48
44 Uses cold start if cold==True, otherwise uses warm start. A cold start means 49 Uses cold start if cold==True, otherwise uses warm start. A cold start means
45 none of the Chromium files are in the disk cache. A warm start assumes the OS 50 none of the Chromium files are in the disk cache. A warm start assumes the OS
46 has already cached much of Chromium's content. For warm tests, you should 51 has already cached much of Chromium's content. For warm tests, you should
47 repeat the page set to ensure it's cached. 52 repeat the page set to ensure it's cached.
48 53
49 The startup URL is taken from the page set's startup_url. This 54 The startup URL is taken from the page set's startup_url. This
50 allows the testing of multiple different URLs in a single benchmark. 55 allows the testing of multiple different URLs in a single benchmark.
51 """ 56 """
52 57
53 def __init__(self, cold=False): 58 def __init__(self, cold=False):
54 super(StartWithUrl, self).__init__(cold=cold, 59 super(StartWithUrl, self).__init__(cold=cold,
55 action_name_to_run='RunNavigateSteps') 60 action_name_to_run='RunNavigateSteps')
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698