Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 714273003: [Autofill, Clean-up] Clean up the Autofill metrics tests. (Closed)

Created:
6 years, 1 month ago by Ilya Sherman
Modified:
6 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Autofill, Clean-up] Clean up the Autofill metrics tests. This cleanup should also allow us to make all the methods defined on the AutofillMetrics class be static methods. BUG=none TEST=components_unittests R=thestig@chromium.org Committed: https://crrev.com/c66fe2a92e081ae6c4e8923cdadda2cb4f6890a4 Cr-Commit-Position: refs/heads/master@{#303757}

Patch Set 1 #

Total comments: 2

Patch Set 2 : anonymouse -> anonymous #

Unified diffs Side-by-side diffs Delta from patch set Stats (+464 lines, -453 lines) Patch
M components/autofill/core/browser/autofill_metrics.cc View 1 6 chunks +86 lines, -88 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 24 chunks +378 lines, -365 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Ilya Sherman
6 years, 1 month ago (2014-11-11 23:05:07 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/714273003/diff/1/components/autofill/core/browser/autofill_metrics.cc File components/autofill/core/browser/autofill_metrics.cc (right): https://codereview.chromium.org/714273003/diff/1/components/autofill/core/browser/autofill_metrics.cc#newcode64 components/autofill/core/browser/autofill_metrics.cc:64: // NOTE: This is defined outside of the ...
6 years, 1 month ago (2014-11-11 23:16:05 UTC) #2
Ilya Sherman
https://codereview.chromium.org/714273003/diff/1/components/autofill/core/browser/autofill_metrics.cc File components/autofill/core/browser/autofill_metrics.cc (right): https://codereview.chromium.org/714273003/diff/1/components/autofill/core/browser/autofill_metrics.cc#newcode64 components/autofill/core/browser/autofill_metrics.cc:64: // NOTE: This is defined outside of the anonymouse ...
6 years, 1 month ago (2014-11-11 23:39:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714273003/20001
6 years, 1 month ago (2014-11-11 23:40:10 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-12 00:25:49 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 00:26:27 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c66fe2a92e081ae6c4e8923cdadda2cb4f6890a4
Cr-Commit-Position: refs/heads/master@{#303757}

Powered by Google App Engine
This is Rietveld 408576698