Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 714223002: Move SkDocument_PDF.cpp into pdf.gypi - now standard PDF API (Closed)

Created:
6 years, 1 month ago by hal.canary
Modified:
6 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Move SkDocument_PDF.cpp into pdf.gypi - now standard PDF API TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/a27ef58a50245fd1c55f92dca4e7a52f7b82f297

Patch Set 1 #

Patch Set 2 : SK_API #

Patch Set 3 : just SkDocument_PDF.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gyp/pdf.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/pdf.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714223002/1
6 years, 1 month ago (2014-11-11 20:43:22 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-11 20:43:23 UTC) #3
hal.canary
ptal - bring SkDocument into the pdf core gypi
6 years, 1 month ago (2014-11-11 21:13:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714223002/40001
6 years, 1 month ago (2014-11-16 16:16:36 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-16 16:16:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714223002/40001
6 years, 1 month ago (2014-11-16 16:26:46 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-16 16:26:58 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a27ef58a50245fd1c55f92dca4e7a52f7b82f297

Powered by Google App Engine
This is Rietveld 408576698