Issue 714213003: Input events are broken in skydb

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 714213003: Input events are broken in skydb (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
Elliot Glaysher

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Input events are broken in skydb When we removed Aura from the build, we broke event targeting. This CL hacks around the issue by blindly forwarding events from the root view to the content view in skydb. Once we have proper event targeting, we should rip out this code. R=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4c9c2c5eb3e1b9c1d95d4237c590d5514e0b9759

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -1 line)			Patch
M	mojo/services/window_manager/window_manager_app.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/services/window_manager/window_manager_app.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sky/tools/debugger/debugger.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	sky/tools/debugger/debugger.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

6 years, 1 month ago (2014-11-12 18:32:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4c9c2c5eb3e1b9c1d95d4237c590d5514e0b9759 (presubmit successful).

Expand Messages | Collapse Messages