cc: Remove PicturePileBase

cc/test/test_picture_pile.h

Index: cc/test/test_picture_pile.h
diff --git a/cc/test/test_picture_pile.h b/cc/test/test_picture_pile.h
new file mode 100644
index 0000000000000000000000000000000000000000..746a8c3ead17d50f81ab394cc47e0884940068e6
--- /dev/null
+++ b/cc/test/test_picture_pile.h
@@ -0,0 +1,53 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_TEST_PICTURE_PILE_H_
+#define CC_TEST_PICTURE_PILE_H_
+
+#include "cc/resources/picture_pile.h"
+
+namespace cc {
+
+class TestPicturePile : public PicturePile {

[danakj, 2014/11/12 19:56:38]

I know this class already existed (and that we have some TestFoo classes
already, regrettably) but since it's being promoted to top-level class here, can
you please rename this to FakePicturePile? "Test" as a prefix is not meaningful,
and we're trying to do better than that now. Fake refers to an implementation
that can override things or change behaviours etc.

[hendrikw, 2014/11/12 20:25:42]

Acknowledged.

+ public:
+  ~TestPicturePile() override {}
+
+  using PicturePile::buffer_pixels;
+  using PicturePile::CanRasterSlowTileCheck;
+  using PicturePile::Clear;
+
+  PictureMap& picture_map() { return picture_map_; }
+  const gfx::Rect& recorded_viewport() const { return recorded_viewport_; }
+
+  bool CanRasterLayerRect(gfx::Rect layer_rect) {
+    layer_rect.Intersect(gfx::Rect(tiling_.tiling_size()));
+    if (recorded_viewport_.Contains(layer_rect))
+      return true;
+    return CanRasterSlowTileCheck(layer_rect);
+  }
+
+  bool HasRecordings() const { return has_any_recordings_; }
+
+  void SetRecordedViewportForTesting(const gfx::Rect& viewport) {
+    recorded_viewport_ = viewport;
+  }
+
+  void SetHasAnyRecordingsForTesting(bool has_recordings) {
+    has_any_recordings_ = has_recordings;
+  }
+
+  TilingData& tiling() { return tiling_; }
+
+  bool is_solid_color() const { return is_solid_color_; }
+  SkColor solid_color() const { return solid_color_; }
+
+  void SetPixelRecordDistanceForTesting(int d) { pixel_record_distance_ = d; }

[danakj, 2014/11/12 19:56:38]

remove ForTesting in a test class

[hendrikw, 2014/11/12 20:25:42]

Acknowledged.

+
+  typedef PicturePile::PictureInfo PictureInfo;
+  typedef PicturePile::PictureMapKey PictureMapKey;
+  typedef PicturePile::PictureMap PictureMap;
+};
+}  // namespace cc
+
+#endif  // CC_TEST_PICTURE_PILE_H_