cc: Remove PicturePileBase

cc/test/fake_picture_pile.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_TEST_FAKE_PICTURE_PILE_H_
+#define CC_TEST_FAKE_PICTURE_PILE_H_
+
+#include "cc/resources/picture_pile.h"
+
+namespace cc {
+
+class FakePicturePile : public PicturePile {
+ public:
+  ~FakePicturePile() override {}
+
+  using PicturePile::buffer_pixels;
+  using PicturePile::CanRasterSlowTileCheck;
+  using PicturePile::Clear;
+
+  PictureMap& picture_map() { return picture_map_; }
+  const gfx::Rect& recorded_viewport() const { return recorded_viewport_; }
+
+  bool CanRasterLayerRect(gfx::Rect layer_rect) {
+    layer_rect.Intersect(gfx::Rect(tiling_.tiling_size()));
+    if (recorded_viewport_.Contains(layer_rect))
+      return true;
+    return CanRasterSlowTileCheck(layer_rect);
+  }
+
+  bool HasRecordings() const { return has_any_recordings_; }

[tfarina, 2014/11/13 15:33:42]

bool has_any_recordings() const { .. }
+
void set_has_any_recordings() { ... }

?

[danakj, 2014/11/13 16:59:13]

Meh... they could be formatted that way, but a) this is legal and b) this is
test code. So I don't feel strongly either way.

+
+  void SetRecordedViewport(const gfx::Rect& viewport) {

[tfarina, 2014/11/13 15:33:42]

set_recorded_viewport?

+    recorded_viewport_ = viewport;
+  }
+
+  void SetHasAnyRecordings(bool has_recordings) {
+    has_any_recordings_ = has_recordings;
+  }
+
+  TilingData& tiling() { return tiling_; }
+
+  bool is_solid_color() const { return is_solid_color_; }

[tfarina, 2014/11/13 15:33:42]

in c++11 you don't need to initialize this member variable in the constructor
anymore? Does it get set to false automatically? Sorry, I don't remember.
Haven't written C++ for some time now.

[danakj, 2014/11/13 16:59:13]

You do need to initialize, looks like that is missing from the base class.

+  SkColor solid_color() const { return solid_color_; }
+
+  void SetPixelRecordDistance(int d) { pixel_record_distance_ = d; }

[tfarina, 2014/11/13 15:33:42]

set_ ....?

+
+  typedef PicturePile::PictureInfo PictureInfo;

[tfarina, 2014/11/13 15:33:42]

these typedefs should be before the constructor, all above.

+  typedef PicturePile::PictureMapKey PictureMapKey;
+  typedef PicturePile::PictureMap PictureMap;
+};

[tfarina, 2014/11/13 15:33:42]

DISALLOW_COPY_AND_ASSIGN?

+}  // namespace cc

[tfarina, 2014/11/13 15:33:42]

add empty line above?

+
+#endif  // CC_TEST_FAKE_PICTURE_PILE_H_