Source/core/css/resolver/StyleResolverState.h - Issue 714163002: Remove RenderStyle member from FontBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleResolverState.h

Issue 714163002: Remove RenderStyle member from FontBuilder. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Ensure font is created before taking animation snapshot. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/StyleResolverState.h

diff --git a/Source/core/css/resolver/StyleResolverState.h b/Source/core/css/resolver/StyleResolverState.h

index c7ed24ff6977888fbf7a4c90b587b0c580936e76..b0048dc5d402190c5bb6a2cce094ac2e035e2922 100644

--- a/Source/core/css/resolver/StyleResolverState.h

+++ b/Source/core/css/resolver/StyleResolverState.h

@@ -65,7 +65,7 @@ public:

// FIXME: Improve RAII of StyleResolverState to remove this function.

m_style = style;

m_cssToLengthConversionData = CSSToLengthConversionData(m_style.get(), rootElementStyle(), document().renderView(), m_style->effectiveZoom());

- m_fontBuilder.setStyle(m_style.get());

+ m_fontBuilder.setFontDescription(m_style->fontDescription());

}

const RenderStyle* style() const { return m_style.get(); }

RenderStyle* style() { return m_style.get(); }