Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1730)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 714133002: Add more management policy checking after extension installed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add new comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 0d7905fbd84226cb78a70a4f73b57e6ce1942bde..4c09b9302fcdc4788a99664c7e54c1d6fda667aa 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -85,6 +85,7 @@
#include "content/public/browser/storage_partition.h"
#include "content/public/common/content_constants.h"
#include "content/public/test/test_utils.h"
+#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
#include "extensions/browser/external_provider_interface.h"
@@ -3845,7 +3846,7 @@ TEST_F(ExtensionServiceTest, ManagementPolicyRequiresEnable) {
service()->DisableExtension(good_crx, Extension::DISABLE_USER_ACTION);
EXPECT_EQ(1u, registry()->disabled_extensions().size());
- // Register an ExtensionMnagementPolicy that requires the extension to remain
+ // Register an ExtensionManagementPolicy that requires the extension to remain
// enabled.
GetManagementPolicy()->UnregisterAllProviders();
extensions::TestManagementPolicyProvider provider(
@@ -3858,6 +3859,31 @@ TEST_F(ExtensionServiceTest, ManagementPolicyRequiresEnable) {
EXPECT_EQ(0u, registry()->disabled_extensions().size());
}
+// Tests that extensions disabled by management policy can be installed but
+// will get disabled after installing.
+TEST_F(ExtensionServiceTest, ManagementPolicyProhibitsEnableOnInstalled) {
+ InitializeEmptyExtensionService();
+
+ // Register an ExtensionManagementPolicy that disables all extensions, with
+ // a specified Extension::DisableReason.
+ GetManagementPolicy()->UnregisterAllProviders();
+ extensions::TestManagementPolicyProvider provider(
+ extensions::TestManagementPolicyProvider::MUST_REMAIN_DISABLED);
+ provider.SetDisableReason(Extension::DISABLE_NOT_VERIFIED);
+ GetManagementPolicy()->RegisterProvider(&provider);
+
+ // Attempts to install an extensions, it should be installed but disabled.
+ EXPECT_EQ(0u, registry()->enabled_extensions().size());
+ EXPECT_EQ(0u, registry()->disabled_extensions().size());
+ InstallCRX(data_dir().AppendASCII("good.crx"), INSTALL_WITHOUT_LOAD);
+ EXPECT_EQ(0u, registry()->enabled_extensions().size());
+ EXPECT_EQ(1u, registry()->disabled_extensions().size());
+
+ // Verifies that the disable reason is set properly.
+ EXPECT_EQ(Extension::DISABLE_NOT_VERIFIED,
+ service()->extension_prefs_->GetDisableReasons(kGoodId));
+}
+
// Tests that extensions with conflicting required permissions by enterprise
// policy cannot be installed.
TEST_F(ExtensionServiceTest, PolicyBlockedPermissionNewExtensionInstall) {

Powered by Google App Engine
This is Rietveld 408576698