Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Unified Diff: chrome/browser/extensions/chrome_app_sorting_unittest.cc

Issue 714133002: Add more management policy checking after extension installed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix CrOS compile Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_app_sorting_unittest.cc
diff --git a/chrome/browser/extensions/chrome_app_sorting_unittest.cc b/chrome/browser/extensions/chrome_app_sorting_unittest.cc
index ccd7c1ea3272ded263d4440fd660e2ad6f3a4181..0ee48797790de8a51bd3634f87845a878c053b0b 100644
--- a/chrome/browser/extensions/chrome_app_sorting_unittest.cc
+++ b/chrome/browser/extensions/chrome_app_sorting_unittest.cc
@@ -31,6 +31,7 @@ class ChromeAppSortingAppLocation : public ChromeAppSortingTest {
// Non-apps should not have any app launch ordinal or page ordinal.
prefs()->OnExtensionInstalled(extension_.get(),
Extension::ENABLED,
+ Extension::DISABLE_NONE,
syncer::StringOrdinal(),
std::string());
}
@@ -59,6 +60,7 @@ class ChromeAppSortingAppLaunchOrdinal : public ChromeAppSortingTest {
EXPECT_FALSE(prefs()->IsExtensionDisabled(extension_->id()));
prefs()->OnExtensionInstalled(extension_.get(),
Extension::ENABLED,
+ Extension::DISABLE_NONE,
syncer::StringOrdinal(),
std::string());
}
@@ -111,6 +113,7 @@ class ChromeAppSortingPageOrdinal : public ChromeAppSortingTest {
first_page_ = syncer::StringOrdinal::CreateInitialOrdinal();
prefs()->OnExtensionInstalled(extension_.get(),
Extension::ENABLED,
+ Extension::DISABLE_NONE,
first_page_,
std::string());
EXPECT_TRUE(first_page_.Equals(
@@ -121,6 +124,7 @@ class ChromeAppSortingPageOrdinal : public ChromeAppSortingTest {
// Install without any page preference.
prefs()->OnExtensionInstalled(extension2.get(),
Extension::ENABLED,
+ Extension::DISABLE_NONE,
syncer::StringOrdinal(),
std::string());
EXPECT_TRUE(first_page_.Equals(
@@ -636,6 +640,7 @@ class ChromeAppSortingPreinstalledAppsBase : public PrefsPrepopulatedTestBase {
simple_dict, Extension::NO_FLAGS, &error);
prefs()->OnExtensionInstalled(app1_scoped_.get(),
Extension::ENABLED,
+ Extension::DISABLE_NONE,
syncer::StringOrdinal(),
std::string());
@@ -644,6 +649,7 @@ class ChromeAppSortingPreinstalledAppsBase : public PrefsPrepopulatedTestBase {
simple_dict, Extension::NO_FLAGS, &error);
prefs()->OnExtensionInstalled(app2_scoped_.get(),
Extension::ENABLED,
+ Extension::DISABLE_NONE,
syncer::StringOrdinal(),
std::string());
@@ -830,6 +836,7 @@ class ChromeAppSortingDefaultOrdinalsBase : public ChromeAppSortingTest {
virtual void InstallApps() {
prefs()->OnExtensionInstalled(app_.get(),
Extension::ENABLED,
+ Extension::DISABLE_NONE,
syncer::StringOrdinal(),
std::string());
}
@@ -877,6 +884,7 @@ class ChromeAppSortingDefaultOrdinalOverriddenByInstallPage
install_page_ = default_page_ordinal_.CreateAfter();
prefs()->OnExtensionInstalled(app_.get(),
Extension::ENABLED,
+ Extension::DISABLE_NONE,
install_page_,
std::string());
}

Powered by Google App Engine
This is Rietveld 408576698