Add more management policy checking after extension installed

extensions/browser/extension_prefs.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_EXTENSION_PREFS_H_
 #define EXTENSIONS_BROWSER_EXTENSION_PREFS_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 160 matching lines @@
   // the extension, this will return false. Generally you should use
   // ExtensionService::IsExtensionEnabled instead.
   bool IsExtensionDisabled(const std::string& id) const;
 
   // Get/Set the order that the browser actions appear in the toolbar.
   ExtensionIdList GetToolbarOrder();
   void SetToolbarOrder(const ExtensionIdList& extension_ids);
 
   // Called when an extension is installed, so that prefs get created.
   // If |page_ordinal| is invalid then a page will be found for the App.
+  // |initial_disable_reason| is the disable reason if |initial_state| is set
+  // to disable the extension initially, if applicable.
   // |install_flags| are a bitmask of extension::InstallFlags.
   void OnExtensionInstalled(const Extension* extension,
                             Extension::State initial_state,
+                            Extension::DisableReason initial_disable_reason,
                             const syncer::StringOrdinal& page_ordinal,
                             int install_flags,
                             const std::string& install_parameter);
   // OnExtensionInstalled with no install flags.
   void OnExtensionInstalled(const Extension* extension,
                             Extension::State initial_state,
+                            Extension::DisableReason initial_disable_reason,
                             const syncer::StringOrdinal& page_ordinal,
                             const std::string& install_parameter) {
     OnExtensionInstalled(extension,
                          initial_state,
+                         initial_disable_reason,
                          page_ordinal,
                          kInstallFlagNone,
                          install_parameter);
   }
 
   // Called when an extension is uninstalled, so that prefs get cleaned up.
   void OnExtensionUninstalled(const std::string& extension_id,
                               const Manifest::Location& location,
                               bool external_uninstall);
 
@@ skipping 205 matching lines @@
   scoped_ptr<ExtensionsInfo> GetUninstalledExtensionsInfo() const;
 
   // Returns the ExtensionInfo from the prefs for the given extension. If the
   // extension is not present, NULL is returned.
   scoped_ptr<ExtensionInfo> GetInstalledExtensionInfo(
       const std::string& extension_id) const;
 
   // We've downloaded an updated .crx file for the extension, but are waiting
   // to install it.
   //
+  // |initial_disable_reason| is the disable reason if |initial_state| is set
+  // set
+  // to disable the extension initially, if applicable.

[Finnur, 2014/11/11 22:58:03]

This is also confusing to read. Can you revise?

   // |install_flags| are a bitmask of extension::InstallFlags.
   void SetDelayedInstallInfo(const Extension* extension,
                              Extension::State initial_state,
+                             Extension::DisableReason initial_disable_reason,
                              int install_flags,
                              DelayReason delay_reason,
                              const syncer::StringOrdinal& page_ordinal,
                              const std::string& install_parameter);
 
   // Removes any delayed install information we have for the given
   // |extension_id|. Returns true if there was info to remove; false otherwise.
   bool RemoveDelayedInstallInfo(const std::string& extension_id);
 
   // Update the prefs to finish the update for an extension.
@@ skipping 204 matching lines @@
   template <class ExtensionIdContainer>
   void SetExtensionPrefFromContainer(const char* pref,
                                      const ExtensionIdContainer& strings);
 
   // Helper function to populate |extension_dict| with the values needed
   // by a newly installed extension. Work is broken up between this
   // function and FinishExtensionInfoPrefs() to accomodate delayed
   // installations.
   //
   // |install_flags| are a bitmask of extension::InstallFlags.
-  void PopulateExtensionInfoPrefs(const Extension* extension,
-                                  const base::Time install_time,
-                                  Extension::State initial_state,
-                                  int install_flags,
-                                  const std::string& install_parameter,
-                                  base::DictionaryValue* extension_dict);
+  void PopulateExtensionInfoPrefs(
+      const Extension* extension,
+      const base::Time install_time,
+      Extension::State initial_state,
+      Extension::DisableReason initial_disable_reason,
+      int install_flags,
+      const std::string& install_parameter,
+      base::DictionaryValue* extension_dict);
 
   void InitExtensionControlledPrefs(ExtensionPrefValueMap* value_map);
 
   // Helper function to complete initialization of the values in
   // |extension_dict| for an extension install. Also see
   // PopulateExtensionInfoPrefs().
   void FinishExtensionInfoPrefs(
       const std::string& extension_id,
       const base::Time install_time,
       bool needs_sort_ordinal,
@@ skipping 19 matching lines @@
   bool extensions_disabled_;
 
   ObserverList<ExtensionPrefsObserver> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionPrefs);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_EXTENSION_PREFS_H_