Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: chrome/browser/extensions/extension_prefs_unittest.cc

Issue 714133002: Add more management policy checking after extension installed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix CrOS compile Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/./extension_prefs_unittest.h" 5 #include "chrome/browser/extensions/./extension_prefs_unittest.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/prefs/mock_pref_change_callback.h" 10 #include "base/prefs/mock_pref_change_callback.h"
(...skipping 436 matching lines...) Expand 10 before | Expand all | Expand 10 after
447 manifest.SetString(manifest_keys::kVersion, "1." + base::IntToString(num)); 447 manifest.SetString(manifest_keys::kVersion, "1." + base::IntToString(num));
448 base::FilePath path = 448 base::FilePath path =
449 prefs_.extensions_dir().AppendASCII(base::IntToString(num)); 449 prefs_.extensions_dir().AppendASCII(base::IntToString(num));
450 std::string errors; 450 std::string errors;
451 scoped_refptr<Extension> extension = Extension::Create( 451 scoped_refptr<Extension> extension = Extension::Create(
452 path, Manifest::INTERNAL, manifest, Extension::NO_FLAGS, id, &errors); 452 path, Manifest::INTERNAL, manifest, Extension::NO_FLAGS, id, &errors);
453 ASSERT_TRUE(extension.get()) << errors; 453 ASSERT_TRUE(extension.get()) << errors;
454 ASSERT_EQ(id, extension->id()); 454 ASSERT_EQ(id, extension->id());
455 prefs()->SetDelayedInstallInfo(extension.get(), 455 prefs()->SetDelayedInstallInfo(extension.get(),
456 Extension::ENABLED, 456 Extension::ENABLED,
457 Extension::DISABLE_NONE,
457 kInstallFlagNone, 458 kInstallFlagNone,
458 ExtensionPrefs::DELAY_REASON_WAIT_FOR_IDLE, 459 ExtensionPrefs::DELAY_REASON_WAIT_FOR_IDLE,
459 syncer::StringOrdinal(), 460 syncer::StringOrdinal(),
460 std::string()); 461 std::string());
461 } 462 }
462 463
463 // Verifies that we get back expected idle install information previously 464 // Verifies that we get back expected idle install information previously
464 // set by SetIdleInfo. 465 // set by SetIdleInfo.
465 void VerifyIdleInfo(const std::string& id, int num) { 466 void VerifyIdleInfo(const std::string& id, int num) {
466 scoped_ptr<ExtensionInfo> info(prefs()->GetDelayedInstallInfo(id)); 467 scoped_ptr<ExtensionInfo> info(prefs()->GetDelayedInstallInfo(id));
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
572 manifest.Set(manifest_keys::kBackgroundScripts, scripts.release()); 573 manifest.Set(manifest_keys::kBackgroundScripts, scripts.release());
573 base::FilePath path = 574 base::FilePath path =
574 prefs_.extensions_dir().AppendASCII("test_0.2"); 575 prefs_.extensions_dir().AppendASCII("test_0.2");
575 std::string errors; 576 std::string errors;
576 scoped_refptr<Extension> new_extension = Extension::Create( 577 scoped_refptr<Extension> new_extension = Extension::Create(
577 path, Manifest::INTERNAL, manifest, Extension::NO_FLAGS, id_, &errors); 578 path, Manifest::INTERNAL, manifest, Extension::NO_FLAGS, id_, &errors);
578 ASSERT_TRUE(new_extension.get()) << errors; 579 ASSERT_TRUE(new_extension.get()) << errors;
579 ASSERT_EQ(id_, new_extension->id()); 580 ASSERT_EQ(id_, new_extension->id());
580 prefs()->SetDelayedInstallInfo(new_extension.get(), 581 prefs()->SetDelayedInstallInfo(new_extension.get(),
581 Extension::ENABLED, 582 Extension::ENABLED,
583 Extension::DISABLE_NONE,
582 kInstallFlagNone, 584 kInstallFlagNone,
583 ExtensionPrefs::DELAY_REASON_WAIT_FOR_IDLE, 585 ExtensionPrefs::DELAY_REASON_WAIT_FOR_IDLE,
584 syncer::StringOrdinal(), 586 syncer::StringOrdinal(),
585 "Param"); 587 "Param");
586 588
587 // Finish idle installation 589 // Finish idle installation
588 ASSERT_TRUE(prefs()->FinishDelayedInstallInfo(id_)); 590 ASSERT_TRUE(prefs()->FinishDelayedInstallInfo(id_));
589 } 591 }
590 592
591 void Verify() override { 593 void Verify() override {
(...skipping 19 matching lines...) Expand all
611 }; 613 };
612 TEST_F(ExtensionPrefsFinishDelayedInstallInfo, FinishDelayedInstallInfo) {} 614 TEST_F(ExtensionPrefsFinishDelayedInstallInfo, FinishDelayedInstallInfo) {}
613 615
614 class ExtensionPrefsOnExtensionInstalled : public ExtensionPrefsTest { 616 class ExtensionPrefsOnExtensionInstalled : public ExtensionPrefsTest {
615 public: 617 public:
616 void Initialize() override { 618 void Initialize() override {
617 extension_ = prefs_.AddExtension("on_extension_installed"); 619 extension_ = prefs_.AddExtension("on_extension_installed");
618 EXPECT_FALSE(prefs()->IsExtensionDisabled(extension_->id())); 620 EXPECT_FALSE(prefs()->IsExtensionDisabled(extension_->id()));
619 prefs()->OnExtensionInstalled(extension_.get(), 621 prefs()->OnExtensionInstalled(extension_.get(),
620 Extension::DISABLED, 622 Extension::DISABLED,
623 Extension::DISABLE_NOT_VERIFIED,
621 syncer::StringOrdinal(), 624 syncer::StringOrdinal(),
622 "Param"); 625 "Param");
623 } 626 }
624 627
625 void Verify() override { 628 void Verify() override {
626 EXPECT_TRUE(prefs()->IsExtensionDisabled(extension_->id())); 629 EXPECT_TRUE(prefs()->IsExtensionDisabled(extension_->id()));
630 EXPECT_EQ(Extension::DISABLE_NOT_VERIFIED,
631 prefs()->GetDisableReasons(extension_->id()));
627 EXPECT_EQ(std::string("Param"), prefs()->GetInstallParam(extension_->id())); 632 EXPECT_EQ(std::string("Param"), prefs()->GetInstallParam(extension_->id()));
628 } 633 }
629 634
630 private: 635 private:
631 scoped_refptr<Extension> extension_; 636 scoped_refptr<Extension> extension_;
632 }; 637 };
633 TEST_F(ExtensionPrefsOnExtensionInstalled, 638 TEST_F(ExtensionPrefsOnExtensionInstalled,
634 ExtensionPrefsOnExtensionInstalled) {} 639 ExtensionPrefsOnExtensionInstalled) {}
635 640
636 class ExtensionPrefsAppDraggedByUser : public ExtensionPrefsTest { 641 class ExtensionPrefsAppDraggedByUser : public ExtensionPrefsTest {
637 public: 642 public:
638 void Initialize() override { 643 void Initialize() override {
639 extension_ = prefs_.AddExtension("on_extension_installed"); 644 extension_ = prefs_.AddExtension("on_extension_installed");
640 EXPECT_FALSE(prefs()->WasAppDraggedByUser(extension_->id())); 645 EXPECT_FALSE(prefs()->WasAppDraggedByUser(extension_->id()));
641 prefs()->OnExtensionInstalled(extension_.get(), 646 prefs()->OnExtensionInstalled(extension_.get(),
642 Extension::ENABLED, 647 Extension::ENABLED,
648 Extension::DISABLE_NONE,
643 syncer::StringOrdinal(), 649 syncer::StringOrdinal(),
644 std::string()); 650 std::string());
645 } 651 }
646 652
647 void Verify() override { 653 void Verify() override {
648 // Set the flag and see if it persisted. 654 // Set the flag and see if it persisted.
649 prefs()->SetAppDraggedByUser(extension_->id()); 655 prefs()->SetAppDraggedByUser(extension_->id());
650 EXPECT_TRUE(prefs()->WasAppDraggedByUser(extension_->id())); 656 EXPECT_TRUE(prefs()->WasAppDraggedByUser(extension_->id()));
651 657
652 // Make sure it doesn't change on consecutive calls. 658 // Make sure it doesn't change on consecutive calls.
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
871 EXPECT_FALSE(prefs()->IsExtensionBlacklisted(extension_a_->id())); 877 EXPECT_FALSE(prefs()->IsExtensionBlacklisted(extension_a_->id()));
872 EXPECT_EQ(empty_ids, prefs()->GetBlacklistedExtensions()); 878 EXPECT_EQ(empty_ids, prefs()->GetBlacklistedExtensions());
873 } 879 }
874 880
875 private: 881 private:
876 scoped_refptr<const Extension> extension_a_; 882 scoped_refptr<const Extension> extension_a_;
877 }; 883 };
878 TEST_F(ExtensionPrefsBlacklistState, ExtensionPrefsBlacklistState) {} 884 TEST_F(ExtensionPrefsBlacklistState, ExtensionPrefsBlacklistState) {}
879 885
880 } // namespace extensions 886 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698