Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 714113002: Move from libstlport to libc++ for Android framework builds (Closed)

Created:
6 years, 1 month ago by djsollen
Modified:
6 years, 1 month ago
Reviewers:
scroggo, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Move from libstlport to libc++ for Android framework builds Committed: https://skia.googlesource.com/skia/+/ce259510a738fab05a0d456440104f5aba1c9d72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M platform_tools/android/bin/android_gdbserver View 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/android/bin/android_perf View 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/android/gyp_gen/makefile_writer.py View 2 chunks +0 lines, -9 lines 0 comments Download
M platform_tools/android/gyp_gen/tool_makefile_writer.py View 1 chunk +0 lines, -2 lines 0 comments Download
M platform_tools/android/tests/expectations/Android.mk View 1 chunk +0 lines, -1 line 0 comments Download
M platform_tools/android/tests/expectations/tool/Android.mk View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
djsollen
see https://android-review.googlesource.com/#/c/113924/1
6 years, 1 month ago (2014-11-11 13:10:56 UTC) #2
tomhudson
lgtm Leon will know better than me about completeness.
6 years, 1 month ago (2014-11-11 13:55:21 UTC) #3
scroggo
On 2014/11/11 13:55:21, tomhudson wrote: > lgtm > > Leon will know better than me ...
6 years, 1 month ago (2014-11-11 14:53:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714113002/1
6 years, 1 month ago (2014-11-11 14:54:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ce259510a738fab05a0d456440104f5aba1c9d72
6 years, 1 month ago (2014-11-11 15:02:06 UTC) #7
scroggo
6 years, 1 month ago (2014-11-11 21:57:12 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/718793003/ by scroggo@google.com.

The reason for reverting is: The code this depends on is not ready yet. We can
submit once https://android-review.googlesource.com/#/c/113924/ is submitted..

Powered by Google App Engine
This is Rietveld 408576698