Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Side by Side Diff: Source/core/rendering/RenderObject.cpp

Issue 714083003: Revert "Move some scroll invalidations to the paint invalidation phase" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 3141 matching lines...) Expand 10 before | Expand all | Expand 10 after
3152 void RenderObject::invalidatePaintIncludingNonCompositingDescendantsInternal(con st RenderLayerModelObject* paintInvalidationContainer) 3152 void RenderObject::invalidatePaintIncludingNonCompositingDescendantsInternal(con st RenderLayerModelObject* paintInvalidationContainer)
3153 { 3153 {
3154 invalidatePaintUsingContainer(paintInvalidationContainer, previousPaintInval idationRect(), PaintInvalidationLayer); 3154 invalidatePaintUsingContainer(paintInvalidationContainer, previousPaintInval idationRect(), PaintInvalidationLayer);
3155 3155
3156 for (RenderObject* child = slowFirstChild(); child; child = child->nextSibli ng()) { 3156 for (RenderObject* child = slowFirstChild(); child; child = child->nextSibli ng()) {
3157 if (!child->isPaintInvalidationContainer()) 3157 if (!child->isPaintInvalidationContainer())
3158 child->invalidatePaintIncludingNonCompositingDescendantsInternal(pai ntInvalidationContainer); 3158 child->invalidatePaintIncludingNonCompositingDescendantsInternal(pai ntInvalidationContainer);
3159 } 3159 }
3160 } 3160 }
3161 3161
3162 void forceRecomputePaintInvalidationRectsIncludingNonCompositingDescendants(Rend erObject* renderer)
3163 {
3164 // We clear the previous paint invalidation rect as it's wrong (paint invali ation container
3165 // changed, ...). Forcing a full invalidation will make us recompute it. Als o we are not
3166 // changing the previous position from our paint invalidation container, whi ch is fine as
3167 // we want a full paint invalidation anyway.
3168 renderer->setPreviousPaintInvalidationRect(LayoutRect());
3169 renderer->setShouldDoFullPaintInvalidation();
3170
3171 for (RenderObject* child = renderer->slowFirstChild(); child; child = child- >nextSibling()) {
3172 if (!child->isPaintInvalidationContainer())
3173 forceRecomputePaintInvalidationRectsIncludingNonCompositingDescendan ts(child);
3174 }
3175 }
3176
3162 3177
3163 } // namespace blink 3178 } // namespace blink
3164 3179
3165 #ifndef NDEBUG 3180 #ifndef NDEBUG
3166 3181
3167 void showTree(const blink::RenderObject* object) 3182 void showTree(const blink::RenderObject* object)
3168 { 3183 {
3169 if (object) 3184 if (object)
3170 object->showTreeForThis(); 3185 object->showTreeForThis();
3171 } 3186 }
(...skipping 13 matching lines...) Expand all
3185 { 3200 {
3186 if (object1) { 3201 if (object1) {
3187 const blink::RenderObject* root = object1; 3202 const blink::RenderObject* root = object1;
3188 while (root->parent()) 3203 while (root->parent())
3189 root = root->parent(); 3204 root = root->parent();
3190 root->showRenderTreeAndMark(object1, "*", object2, "-", 0); 3205 root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
3191 } 3206 }
3192 } 3207 }
3193 3208
3194 #endif 3209 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698