Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 714013002: Remove some more zoom-related code. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove some more zoom-related code. -Remove all references to zoomFactor. -Remove zoomLevels. -Remove unused m_zoom on StyleVisualData. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0e1a8f90a0552934e3474de0424755d6fc4ba233

Patch Set 1 #

Patch Set 2 : merge to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -225 lines) Patch
M sky/engine/core/css/CSSImageSetValue.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Touch.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/dom/TreeScope.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/events/MouseRelatedEvent.cpp View 3 chunks +2 lines, -22 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.h View 2 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.cpp View 3 chunks +1 line, -36 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 2 chunks +1 line, -11 lines 0 comments Download
M sky/engine/core/rendering/RenderView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 2 chunks +4 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/style/StyleVisualData.h View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/rendering/style/StyleVisualData.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/public/web/WebView.h View 1 chunk +0 lines, -29 lines 0 comments Download
M sky/engine/public/web/WebViewClient.h View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 4 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 5 chunks +1 line, -65 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
esprehn
This removes a bunch of text zoom stuff too, we might want to keep (or ...
6 years, 1 month ago (2014-11-11 02:06:32 UTC) #2
esprehn
lgtm
6 years, 1 month ago (2014-11-11 02:06:35 UTC) #3
ojan
Committed patchset #2 (id:20001) manually as 0e1a8f90a0552934e3474de0424755d6fc4ba233 (presubmit successful).
6 years, 1 month ago (2014-11-11 02:08:50 UTC) #4
ojan
6 years, 1 month ago (2014-11-11 03:38:27 UTC) #5
Message was sent while issue was closed.
FWIW, as best I can tell, the text zoom stuff was already removed before this
patch. This just removes the remaining plumbing.

Powered by Google App Engine
This is Rietveld 408576698