Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 713973003: Add a basic benchmark for creating DOM. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium, ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : ojan review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -0 lines) Patch
A sky/benchmarks/dom/creation.sky View 1 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
lgtm https://codereview.chromium.org/713973003/diff/1/sky/benchmarks/dom/creation.sky File sky/benchmarks/dom/creation.sky (right): https://codereview.chromium.org/713973003/diff/1/sky/benchmarks/dom/creation.sky#newcode4 sky/benchmarks/dom/creation.sky:4: var sky = document.documentElement; document.querySelector('sky') ? We're going ...
6 years, 1 month ago (2014-11-11 01:41:37 UTC) #2
esprehn
https://codereview.chromium.org/713973003/diff/1/sky/benchmarks/dom/creation.sky File sky/benchmarks/dom/creation.sky (right): https://codereview.chromium.org/713973003/diff/1/sky/benchmarks/dom/creation.sky#newcode4 sky/benchmarks/dom/creation.sky:4: var sky = document.documentElement; On 2014/11/11 at 01:41:37, ojan ...
6 years, 1 month ago (2014-11-11 01:44:52 UTC) #3
esprehn
6 years, 1 month ago (2014-11-11 01:45:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7362bd7be3410f54beb3df49c17e12278a70a83a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698