Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 713913002: DevTools: merge TracingTimelineUIUtils into TimelineUIUtils (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
caseq, alph, pfeldman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: merge TracingTimelineUIUtils into TimelineUIUtils BUG=428700, 387546 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185113

Patch Set 1 #

Patch Set 2 : Deleted instance refs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+937 lines, -1205 lines) Patch
M LayoutTests/http/tests/inspector/timeline-test.js View 1 3 chunks +2 lines, -7 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-coalescing.html View 1 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-event-causes.html View 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-node-reference.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tracing/timeline-receive-response-event.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tracing/timeline-script-id.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/devtools.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/MemoryCountersGraph.js View 1 2 chunks +2 lines, -4 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineEventOverview.js View 1 2 chunks +3 lines, -5 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFrameModel.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineMemoryOverview.js View 1 3 chunks +3 lines, -6 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineOverviewPane.js View 1 2 chunks +3 lines, -5 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 14 chunks +18 lines, -27 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePresentationModel.js View 1 3 chunks +3 lines, -5 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 1 chunk +866 lines, -104 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 1 11 chunks +16 lines, -20 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineUIUtils.js View 1 1 chunk +0 lines, -998 lines 0 comments Download
M Source/devtools/front_end/timeline/module.json View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
yurys
6 years, 1 month ago (2014-11-10 17:37:56 UTC) #2
loislo
lgtm
6 years, 1 month ago (2014-11-11 09:44:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/713913002/20001
6 years, 1 month ago (2014-11-11 09:45:33 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 10:18:09 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185113

Powered by Google App Engine
This is Rietveld 408576698