Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 71383002: [SPDY] Reenable SPDY/2 for M32 (Closed)

Created:
7 years, 1 month ago by akalin
Modified:
7 years, 1 month ago
Reviewers:
jam, Ryan Hamilton
CC:
chromium-reviews
Visibility:
Public.

Description

[SPDY] Reenable SPDY/2 for M32 This will be merged to the M32 branch and then reverted on trunk. BUG=318651 R=jam@chromium.org, rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234959

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M chrome/browser/io_thread.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
akalin
+rch for review
7 years, 1 month ago (2013-11-13 10:26:19 UTC) #1
Ryan Hamilton
lgtm. i assume this is to allow more time for servers to upgrade to spdy/3.1?
7 years, 1 month ago (2013-11-13 15:08:55 UTC) #2
akalin
On 2013/11/13 15:08:55, Ryan Hamilton wrote: > lgtm. i assume this is to allow more ...
7 years, 1 month ago (2013-11-13 19:24:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/71383002/1
7 years, 1 month ago (2013-11-13 19:27:51 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=35997
7 years, 1 month ago (2013-11-13 19:51:30 UTC) #5
akalin
+jam for OWNERS
7 years, 1 month ago (2013-11-13 23:17:47 UTC) #6
jam
lgtm https://codereview.chromium.org/71383002/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/71383002/diff/1/chrome/common/chrome_switches.cc#newcode745 chrome/common/chrome_switches.cc:745: const char kDisableSpdy2[] = "disable-spdy2"; please sort now
7 years, 1 month ago (2013-11-13 23:19:09 UTC) #7
akalin
addressed comments, landing soon https://codereview.chromium.org/71383002/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/71383002/diff/1/chrome/common/chrome_switches.cc#newcode745 chrome/common/chrome_switches.cc:745: const char kDisableSpdy2[] = "disable-spdy2"; ...
7 years, 1 month ago (2013-11-13 23:39:13 UTC) #8
akalin
7 years, 1 month ago (2013-11-13 23:39:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r234959 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698