Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: Source/core/rendering/FilterEffectRenderer.cpp

Issue 713823005: Factor painting code for filters out of FilterEffectRenderer into FilterPainter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/FilterEffectRenderer.cpp
diff --git a/Source/core/rendering/FilterEffectRenderer.cpp b/Source/core/rendering/FilterEffectRenderer.cpp
index 507ab39abfe27ff43ee80dc1e1a2285d857a5b7d..47c71ce29146fbca7ee89f1f152823f2026dd458 100644
--- a/Source/core/rendering/FilterEffectRenderer.cpp
+++ b/Source/core/rendering/FilterEffectRenderer.cpp
@@ -39,14 +39,12 @@
#include "platform/FloatConversion.h"
#include "platform/LengthFunctions.h"
#include "platform/graphics/ColorSpace.h"
-#include "platform/graphics/GraphicsContext.h"
#include "platform/graphics/ImageFilter.h"
#include "platform/graphics/UnacceleratedImageBufferSurface.h"
#include "platform/graphics/filters/FEColorMatrix.h"
#include "platform/graphics/filters/FEComponentTransfer.h"
#include "platform/graphics/filters/FEDropShadow.h"
#include "platform/graphics/filters/FEGaussianBlur.h"
-#include "platform/graphics/filters/SkiaImageFilterBuilder.h"
#include "platform/graphics/filters/SourceGraphic.h"
#include "wtf/MathExtras.h"
#include <algorithm>
@@ -254,27 +252,6 @@ void FilterEffectRenderer::clearIntermediateResults()
m_lastEffect->clearResultsRecursive();
}
-bool FilterEffectRenderer::beginFilterEffect(GraphicsContext* context, const FloatRect& filterBoxRect)
-{
- SkiaImageFilterBuilder builder(context);
- m_lastEffect->determineFilterPrimitiveSubregion(MapRectForward);
- RefPtr<ImageFilter> imageFilter = builder.build(m_lastEffect.get(), ColorSpaceDeviceRGB);
- if (!imageFilter)
- return false;
- context->save();
- FloatRect boundaries = mapImageFilterRect(imageFilter.get(), filterBoxRect);
- context->translate(filterBoxRect.x(), filterBoxRect.y());
- boundaries.move(-filterBoxRect.x(), -filterBoxRect.y());
- context->beginLayer(1, CompositeSourceOver, &boundaries, ColorFilterNone, imageFilter.get());
- context->translate(-filterBoxRect.x(), -filterBoxRect.y());
- return true;
-}
-
-void FilterEffectRenderer::endFilterEffect(GraphicsContext* context)
-{
- context->endLayer();
- context->restore();
-}
} // namespace blink
« Source/core/paint/FilterPainter.cpp ('K') | « Source/core/rendering/FilterEffectRenderer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698